[core] Upgrade node to v14

[cherniavskii]

Node 12 support ended on April 30th
Node 14 is currently Maintenance LTS, Node 16 - Active LTS (see https://nodejs.org/en/about/releases/)

I didn't update engines entry in our packages, because:

• I'm not sure if it should be considered as breaking change
• technically nothing changes in our packages - we'll just use node v14 in CI and deployment environments

[mui-bot]

These are the results for the performance tests:

Test case	Unit	Min	Max	Median	Mean	σ
Filter 100k rows	ms	243.8	467.4	346.1	339.5	79.238
Sort 100k rows	ms	458.8	814.5	801.5	713	137.297
Select 100k rows	ms	134.2	257.7	213.5	210.78	44.743
Deselect 100k rows	ms	118.8	211	170.3	169.56	35.173

Generated by 🚫 dangerJS against 8a9da27

[oliviertassinari]

I believe it's a breaking change, we list it in #3287

[flaviendelangle]

Equivalent on the core: mui/material-ui#32546

[cherniavskii]

I believe it's a breaking change, we list it in #3287

But if we don't update engines entry in package.json it's not a breaking change, right?

[oliviertassinari]

But if we don't update engines entry in package.json it's not a breaking change, right?

@cherniavskii Right, yes, I have missed this.

[ZeeshanTamboli]

A question, why not directly upgrade to v16 (Active LTS) to avoid upgrading it again next year?

v16
End of life: 30th April, 2024
Maintenance LTS starts soon on 18th Oct, 2022.

v14
End of life: 30th April, 2023

Here it suggests Production applications should only use Active LTS or Maintenance LTS releases.

[cherniavskii]

why not directly upgrade to v16 (Active LTS) to avoid upgrading it again next year?

Good point, I'll upgrade to v16 👍

[oliviertassinari]

A question, why not directly upgrade to v16 (Active LTS) to avoid upgrading it again next year?

In MUI Core, we use (& have used) the lowest possible version of Node (like in the Browser tests) to catch cases where we might start depending on an API that is not supposed by the minimum "engines" value without realizing it.

[cherniavskii]

to catch cases where we might start depending on an API that is not supposed by the minimum "engines" value without realizing it

To be fair, the opposite can happen as well, e.g. we use node v12 but in v16 some API that we use is missing.
But AFAIK we don't use node API directly, the only thing that matters is that we provide commonjs bundle, so that it works with SSR using node v12.

But if we keep using v12, we won't be able to update some of our dependencies like playwright or danger - see dependencies PRs that are currently on hold because of node version incompatibility: https://github.com/mui/mui-x/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Adependencies+label%3A%22On+hold%22

[oliviertassinari]

@cherniavskii +1 to not use Node v12 as it doesn't receive critical bug fixes. To be clear by "API", I was thinking ECMAScript: APIs like optional chaining, Intl, etc.

[cherniavskii]

To be clear by "API", I was thinking ECMAScript: APIs like optional chaining, Intl, etc.

Thanks for the clarification!
We do transpile the code though (except for modern bundle). So unless there's a regression in our bundling method, it should work in v12 just fine

[oliviertassinari]

We do transpile the code though

@cherniavskii It helps a lot but Babel can't transpile all the features of ECMAScript: https://babeljs.io/docs/en/caveats.

[cherniavskii]

We've decided to set minimal supported version of Node to 14 in data grid v6 alpha

[oliviertassinari]

MUI Core is moving forward with upgrading Node in the different CI environments from v12 to v14 to unlock dependency updates.

[oliviertassinari]

this looks like a breaking change for developers

Suggested change

	node 16
	node 14

x the other changes in this file

[michaldudak]

For reference, here's the equivalent PR in Core: mui/material-ui#33642

[joserodolfofreitas]

We discussed about it in one of our meetings.

We decided to move to v14 too as part of v6 #5605

[oliviertassinari]

@joserodolfofreitas For the developers, the same goes for MUI Core: mui/material-ui#32546. The only difference is that v6 will be released later compared to MUI X, so Node.js v16 might be more realistic as the LTS version when the release happens.

For the contributors, the change is done mui/material-ui#33642, 👍 to do the same in MUI X.

[oliviertassinari]

looks good