Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Upgrade node to v14 #4999

Merged
merged 3 commits into from
Aug 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ defaults: &defaults
REACT_DIST_TAG: << parameters.react-dist-tag >>
working_directory: /tmp/mui
docker:
- image: cimg/node:12.22
- image: cimg/node:14.20
# CircleCI has disabled the cache across forks for security reasons.
# Following their official statement, it was a quick solution, they
# are working on providing this feature back with appropriate security measures.
Expand Down
2 changes: 1 addition & 1 deletion .codesandbox/ci.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"buildCommand": "build:codesandbox",
"node": "12",
"node": "14",
"packages": [
"packages/x-license-pro",
"packages/grid/x-data-grid",
Expand Down
2 changes: 1 addition & 1 deletion netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
command = "yarn docs:build && yarn docs:export && yarn storybook:build && yarn storybook:export"

[build.environment]
NODE_VERSION = "12"
NODE_VERSION = "14"
NODE_OPTIONS = "--max_old_space_size=4096"
# Not using `playwright` when building docs.
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD = "1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ describe('<DataGridPro /> - Column pinning', () => {
);
};

it('should scroll when the next cell to focus is covered by the left pinned columns', () => {
it('should scroll when the next cell to focus is covered by the left pinned columns', function test() {
if (isJSDOM) {
// Need layouting
this.skip();
}
render(<TestCase initialState={{ pinnedColumns: { left: ['id'] } }} />);
const virtualScroller = document.querySelector(`.${gridClasses.virtualScroller}`)!;
virtualScroller.scrollLeft = 100;
Expand All @@ -56,7 +60,7 @@ describe('<DataGridPro /> - Column pinning', () => {
});

it('should scroll when the next cell to focus is covered by the right pinned columns', function test() {
if (/jsdom/.test(window.navigator.userAgent)) {
if (isJSDOM) {
// Need layouting
this.skip();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ describe('useGridApiEventHandler', () => {
it('should unsubscribe event listeners registered by uncommitted components', async function test() {
if (
!/jsdom/.test(window.navigator.userAgent) ||
typeof FinalizationRegistry === 'undefined'
typeof FinalizationRegistry === 'undefined' ||
typeof global.gc === 'undefined'
) {
// Needs ability to trigger the garbage collector and support for FinalizationRegistry (added in node 14)
this.skip();
Expand Down Expand Up @@ -50,7 +51,7 @@ describe('useGridApiEventHandler', () => {
expect(apiRef.current.subscribeEvent.callCount).to.equal(2);

unmount();
global.gc!(); // Triggers garbage collector
global.gc(); // Triggers garbage collector
await sleep(50);

// Ensure that both event listeners were unsubscribed
Expand Down