-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Remove legacy editing API #6016
Conversation
These are the results for the performance tests:
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
4f5c705
to
7b84cae
Compare
7b84cae
to
ffb021f
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@m4theushw I guess this solves that issue #5606 The question is does it also save the rest that is listed under the "Editing" section here #3287 |
Closes #5606
Preview: https://deploy-preview-6016--material-ui-x.netlify.app/x/react-data-grid/
Breaking change
[DataGrid] Remove legacy editing API
The editing API that is enabled by default was replaced with a new API that contains better support for server-side persistence, validation and customization. This new editing feature was already available in v5 under the
newEditingApi
experimental flag. In v6, this flag can be removed.<DataGrid - experimentalFeatures={{ newEditingApi: true }} />
For users that didn't migrate to the new editing API in v5, additional work may be needed because the new API is not equivalent to the legacy API. Although, some migration steps are available to help in this task.
editCellPropsChange
event was removed. If you still need it please file a new issue so we can propose an alternative.cellEditCommit
event was removed and theprocessRowUpdate
prop can be used in place. More information, check the docs section about the topic.editRowsModel
andonEditRowsModelChange
props were removed. ThecellModesModel
orrowModesModel
props can be used to achieve the same goal.apiRef.current.stopCellEditMode
to replaceapiRef.current.commitCellChange
apiRef.current.startCellEditMode
to replaceapiRef.current.setCellMode(id, field, 'edit')
apiRef.current.stopRowEditMode
to replaceapiRef.current.commitRowChange
apiRef.current.startRowMode
to replaceapiRef.current.setRowMode(id, 'edit')
cellModesModel
orrowModesModel
props to replaceapiRef.current.setEditRowsModel