[DataGrid] Remove remaining props from legacy editing API #7381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
added
the
component: data grid
m4theushw
force-pushed
the
remove-legacy-editing-props
branch
from
c109fae to
4c80df9
Compare
These are the results for the performance tests:
|
cherniavskii
approved these changes
Jan 4, 2023
| - Use `apiRef.current.startCellEditMode` to replace `apiRef.current.setCellMode(id, field, 'edit')` | ||
| - Use `apiRef.current.stopRowEditMode` to replace `apiRef.current.commitRowChange` | ||
| - Use `apiRef.current.startRowMode` to replace `apiRef.current.setRowMode(id, 'edit')` | ||
| - Use the [`cellModesModel`](https://mui.com/x/react-data-grid/editing/#controlled-mode) or [`rowModesModel`](https://mui.com/x/react-data-grid/editing/#controlled-mode) props to replace `apiRef.current.setEditRowsModel` |
There was a problem hiding this comment.
Worth mentioning that the GridEditRowsModel type was removed
There was a problem hiding this comment.
Well, I think this doesn't need to be explicit because all entry points that require GridEditRowsModel were removed (props and API methods), but I included it in the migration guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6016 I forgot to remove the
editRowsModelandonEditRowsModelChangeprops. At that time the migration guide wasn't updated so I'm also updating it to include the breaking changes from #6016 here. There's no need to update theCHANGELOGbecause they were already released.