Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Create the doc of the new time, date time and date range pickers #6958

Merged
merged 8 commits into from
Nov 24, 2022
Merged

[docs] Create the doc of the new time, date time and date range pickers #6958

merged 8 commits into from
Nov 24, 2022

Conversation

flaviendelangle
Copy link
Member

Follow up on #6902

  • Apply the same copy / adaptation logic as on [docs] Create the doc of the new date pickers #6902
  • Unify the section order and some of the wordings across the new pages
  • Use the grid introduced in the validation page to have clean label on the date range picker doc

@flaviendelangle flaviendelangle self-assigned this Nov 22, 2022
@flaviendelangle flaviendelangle added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Nov 22, 2022
@mui-bot
Copy link

mui-bot commented Nov 22, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-6958--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 712.3 1,129.2 712.3 900.1 170.852
Sort 100k rows ms 653 1,207.7 1,207.7 994.24 224.379
Select 100k rows ms 227 324.2 272.6 274.32 30.992
Deselect 100k rows ms 143.3 249.2 173.2 189.8 38.208

Generated by 🚫 dangerJS against 19d8bcb

@flaviendelangle flaviendelangle marked this pull request as ready for review November 22, 2022 11:06
LukasTy
LukasTy reviewed Nov 24, 2022
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few issues which IMO need to be addressed or issues created for them. 😉
As per usual—I ignored everything in legacy-*. 🙈

docs/data/date-pickers/date-range-picker/BasicDateRangePicker.tsx Outdated Show resolved Hide resolved
docs/data/date-pickers/time-picker/time-picker.md Show resolved Hide resolved
docs/data/date-pickers/time-picker/time-picker.md Show resolved Hide resolved
docs/data/date-pickers/date-time-picker/FormPropsDateTimePickers.tsx Show resolved Hide resolved
docs/data/date-pickers/date-range-picker/CustomInputs.tsx Show resolved Hide resolved
docs/data/date-pickers/date-range-picker/FormPropsDateRangePickers.tsx Show resolved Hide resolved
docs/data/date-pickers/date-range-picker/ResponsiveDateRangePicker.tsx Show resolved Hide resolved
docs/data/date-pickers/date-time-picker/CustomDateTimePicker.tsx Show resolved Hide resolved
docs/data/date-pickers/date-time-picker/CustomDateTimePicker.tsx Show resolved Hide resolved
@LukasTy LukasTy mentioned this pull request Nov 24, 2022
Closed
@flaviendelangle flaviendelangle merged commit b673ec1 into mui:next Nov 24, 2022
@flaviendelangle flaviendelangle deleted the next-pickers-doc branch November 24, 2022 13:34
@flaviendelangle flaviendelangle mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@LukasTy LukasTy LukasTy approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flaviendelangle @mui-bot @LukasTy @alexfauquette