-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Fix toolbar on the new range pickers #6989
Merged
flaviendelangle
merged 14 commits into
mui:next
from
flaviendelangle:range-picker-toolbar
Dec 5, 2022
Merged
[pickers] Fix toolbar on the new range pickers #6989
flaviendelangle
merged 14 commits into
mui:next
from
flaviendelangle:range-picker-toolbar
Dec 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
flaviendelangle
added
bug 🐛
Something doesn't work
component: pickers
This is the name of the generic UI component, not the React module!
labels
Nov 24, 2022
These are the results for the performance tests:
|
flaviendelangle
commented
Nov 29, 2022
packages/x-date-pickers-pro/src/StaticNextDateRangePicker/StaticNextDateRangePicker.tsx
Show resolved
Hide resolved
packages/x-date-pickers-pro/src/internal/hooks/useDesktopRangePicker/useDesktopRangePicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/components/PickersViewLayout/PickersViewLayout.types.ts
Outdated
Show resolved
Hide resolved
LukasTy
reviewed
Dec 2, 2022
packages/x-date-pickers-pro/src/internal/hooks/useDesktopRangePicker/useDesktopRangePicker.tsx
Outdated
Show resolved
Hide resolved
...ges/x-date-pickers-pro/src/internal/hooks/useStaticRangePicker/useStaticRangePicker.types.ts
Outdated
Show resolved
Hide resolved
packages/x-date-pickers-pro/src/internal/hooks/useStaticRangePicker/useStaticRangePicker.tsx
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/components/PickersViewLayout/PickersViewLayout.types.ts
Outdated
Show resolved
Hide resolved
LukasTy
reviewed
Dec 5, 2022
packages/x-date-pickers-pro/src/DateRangePicker/date-range-manager.test.ts
Outdated
Show resolved
Hide resolved
packages/x-date-pickers-pro/src/internal/hooks/useDesktopRangePicker/useDesktopRangePicker.tsx
Outdated
Show resolved
Hide resolved
LukasTy
approved these changes
Dec 5, 2022
flaviendelangle
force-pushed
the
range-picker-toolbar
branch
from
December 5, 2022 12:31
0472a7a
to
77673d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: pickers
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6958 (comment)
We did not pass the props to switch between the start and the end date to the toolbar
Changelog
Breaking changes
The
currentlySelectingRangeEnd
/setCurrentlySelectingRangeEnd
props on the Date Range Picker toolbar have been renamed torangePosition
/onRangePositionChange
.