-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to choose a Media Theme via attribute #269
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #269 +/- ##
==========================================
+ Coverage 80.39% 80.53% +0.13%
==========================================
Files 36 36
Lines 4356 4371 +15
Branches 151 149 -2
==========================================
+ Hits 3502 3520 +18
+ Misses 845 842 -3
Partials 9 9
|
@@ -0,0 +1,6 @@ | |||
declare module 'media-chrome' { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 lgtm
this change adds the ability to use a different theme via a simple
theme="media-theme-goldshine"
attribute ✨it required some changes to the html tagged template renderer.
added support for unsafe static values that can make part of the HTML string to be process by the template parser.