Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to choose a Media Theme via attribute #269

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Jun 24, 2022

this change adds the ability to use a different theme via a simple theme="media-theme-goldshine" attribute ✨

it required some changes to the html tagged template renderer.
added support for unsafe static values that can make part of the HTML string to be process by the template parser.

SCR-20220624-kk4

@luwes luwes self-assigned this Jun 24, 2022
@vercel
Copy link

vercel bot commented Jun 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 9:38PM (UTC)
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 9:38PM (UTC)
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 9:38PM (UTC)
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 9:38PM (UTC)
elements-demo-vue ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 9:38PM (UTC)

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #269 (154295c) into main (b1efffb) will increase coverage by 0.13%.
The diff coverage is 88.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
+ Coverage   80.39%   80.53%   +0.13%     
==========================================
  Files          36       36              
  Lines        4356     4371      +15     
  Branches      151      149       -2     
==========================================
+ Hits         3502     3520      +18     
+ Misses        845      842       -3     
  Partials        9        9              
Impacted Files Coverage Δ
packages/mux-player/src/index.ts 73.06% <50.00%> (-0.37%) ⬇️
packages/mux-player/src/helpers.ts 93.85% <71.42%> (-1.57%) ⬇️
packages/mux-player/src/template.ts 93.66% <86.76%> (+0.80%) ⬆️
.../mux-player/src/media-theme-mux/media-theme-mux.ts 78.29% <94.91%> (+0.15%) ⬆️
packages/mux-player/src/html.ts 97.20% <96.00%> (-0.37%) ⬇️
packages/mux-player/src/media-theme-mux/styles.css 100.00% <100.00%> (ø)

@@ -0,0 +1,6 @@
declare module 'media-chrome' {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Copy link
Contributor

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@luwes luwes merged commit 77d0386 into muxinc:main Jul 12, 2022
@luwes luwes deleted the theme-prop branch July 12, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants