feat!: new quic-rpc, simlified generics, bump MSRV to 1.76 #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
refactor-api
branch
from
2ce0277 to
b21f9cc
Compare
|
Needs rebase |
Frando
force-pushed
the
refactor-api-simplify-client-generics
branch
from
e39a486 to
68b341b
Compare
|
Rebased this. Needs a quic-rpc release first though. |
|
release is done |
|
Rebased again and bumped quic-rpc. Should be good to go now. Edit: quic-rpc has MSRV 1.76, so bumped ours from 1.75 to 1.76 as well. |
Frando
changed the title
dignifiedquire
approved these changes
May 23, 2024
|
working on deps updates here: n0-computer/quic-rpc#80 |
dignifiedquire
changed the title
dignifiedquire
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description Adapts iroh for n0-computer/quic-rpc#76 Wit this change, a quic client is `pub type QuicIroh = Iroh<QuinnConnection<RpcService>>` instead of `pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest, ProviderResponse>>` ## Breaking Changes * Increased mimimal supported rust version (MSRV) from 1.75 to 1.76 * The generics of the iroh clients changed: Instead of taking `ProviderRequest, ProviderResponse` as generics, they now take `RpcService` ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant. - [x] All breaking changes documented. --------- Co-authored-by: dignifiedquire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapts iroh for n0-computer/quic-rpc#76
Wit this change, a quic client is
pub type QuicIroh = Iroh<QuinnConnection<RpcService>>instead of
pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest, ProviderResponse>>Breaking Changes
ProviderRequest, ProviderResponseas generics, they now takeRpcServiceNotes & open questions
Change checklist