Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: use Service generic in transport connections #76

Merged
merged 8 commits into from
May 13, 2024
Merged

refactor!: use Service generic in transport connections #76

merged 8 commits into from
May 13, 2024

Conversation

Frando
Copy link
Member

@Frando Frando commented May 6, 2024

This changes the transport connection and endpoint struct to be generic over S: Service instead of In: RpcMessage, Out: RpcMessage. With this change, the public API surface of a crate using quic-rpc can be reduced to only make the service struct public and hide the RPC message types.

E.g. in Iroh, a quic client would now be
Client<QuinnConnection<RpcService>>
instead of
Client<QuinnConnection<ProviderRequest, ProviderResponse>>

Breaking changes

The change breaks all transport types, they are now generic over S: Service instead of In: RpcMessage, Out: RpcMessage.

@Frando Frando mentioned this pull request May 6, 2024
Merged
4 tasks
@dignifiedquire
Copy link
Contributor

much nicer 🔥

@rklaehn
Copy link
Collaborator

rklaehn commented May 13, 2024

OK, so I am trying to come up with cases where this is limiting, but so far can't find any. Also it seems that transport::Connection is unaffected and still has two type parameters. So LGTM.

rklaehn added 2 commits May 13, 2024 11:10
@rklaehn
chore: Update derive-more
78a3250 
maybe it gets rid of the errors
@rklaehn
Merge branch 'main' into refactor/service-conn
ecd7305 
# Conflicts:
#	Cargo.lock
@rklaehn rklaehn force-pushed the refactor/service-conn branch from b52d24e to 2a25a7a Compare May 13, 2024 09:25
@rklaehn
fix: downgrade derive_more to non beta
9235fdf 
to get rid of some weird warnings about non_local_definitions from
derive_more macros
@rklaehn rklaehn force-pushed the refactor/service-conn branch from 2a25a7a to 9235fdf Compare May 13, 2024 09:47
@rklaehn rklaehn self-requested a review May 13, 2024 12:20
@rklaehn rklaehn merged commit 64ed5ef into main May 13, 2024
15 checks passed
@rklaehn rklaehn deleted the refactor/service-conn branch May 13, 2024 12:59
github-merge-queue bot pushed a commit to n0-computer/iroh that referenced this pull request May 24, 2024
@Frando @dignifiedquire
feat!: new quic-rpc, simlified generics, bump MSRV to 1.76 (#2268)
f999e5f 
## Description

Adapts iroh for n0-computer/quic-rpc#76

Wit this change, a quic client is
`pub type QuicIroh = Iroh<QuinnConnection<RpcService>>`
instead of
`pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest,
ProviderResponse>>`

## Breaking Changes
* Increased mimimal supported rust version (MSRV) from 1.75 to 1.76
* The generics of the iroh clients changed: Instead of taking
`ProviderRequest, ProviderResponse` as generics, they now take
`RpcService`

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.

---------

Co-authored-by: dignifiedquire <[email protected]>
github-merge-queue bot pushed a commit to n0-computer/iroh that referenced this pull request May 24, 2024
@Frando @dignifiedquire
feat!: new quic-rpc, simlified generics, bump MSRV to 1.76 (#2268)
1e31dcf 
## Description

Adapts iroh for n0-computer/quic-rpc#76

Wit this change, a quic client is
`pub type QuicIroh = Iroh<QuinnConnection<RpcService>>`
instead of
`pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest,
ProviderResponse>>`

## Breaking Changes
* Increased mimimal supported rust version (MSRV) from 1.75 to 1.76
* The generics of the iroh clients changed: Instead of taking
`ProviderRequest, ProviderResponse` as generics, they now take
`RpcService`

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.

---------

Co-authored-by: dignifiedquire <[email protected]>
rklaehn pushed a commit to n0-computer/iroh-blobs that referenced this pull request Oct 22, 2024
@Frando @dignifiedquire
feat!: new quic-rpc, simlified generics, bump MSRV to 1.76 (#2268)
aa33e9c 
## Description

Adapts iroh for n0-computer/quic-rpc#76

Wit this change, a quic client is
`pub type QuicIroh = Iroh<QuinnConnection<RpcService>>`
instead of
`pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest,
ProviderResponse>>`

## Breaking Changes
* Increased mimimal supported rust version (MSRV) from 1.75 to 1.76
* The generics of the iroh clients changed: Instead of taking
`ProviderRequest, ProviderResponse` as generics, they now take
`RpcService`

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.

---------

Co-authored-by: dignifiedquire <[email protected]>
rklaehn pushed a commit to n0-computer/iroh-blobs that referenced this pull request Oct 22, 2024
@Frando @dignifiedquire
feat!: new quic-rpc, simlified generics, bump MSRV to 1.76 (#2268)
fcc416b 
## Description

Adapts iroh for n0-computer/quic-rpc#76

Wit this change, a quic client is
`pub type QuicIroh = Iroh<QuinnConnection<RpcService>>`
instead of
`pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest,
ProviderResponse>>`

## Breaking Changes
* Increased mimimal supported rust version (MSRV) from 1.75 to 1.76
* The generics of the iroh clients changed: Instead of taking
`ProviderRequest, ProviderResponse` as generics, they now take
`RpcService`

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.

---------

Co-authored-by: dignifiedquire <[email protected]>
matheus23 pushed a commit to n0-computer/iroh-doctor that referenced this pull request Oct 22, 2024
@Frando @dignifiedquire
feat!: new quic-rpc, simlified generics, bump MSRV to 1.76 (#2268)
afc680a 
## Description

Adapts iroh for n0-computer/quic-rpc#76

Wit this change, a quic client is
`pub type QuicIroh = Iroh<QuinnConnection<RpcService>>`
instead of
`pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest,
ProviderResponse>>`

## Breaking Changes
* Increased mimimal supported rust version (MSRV) from 1.75 to 1.76
* The generics of the iroh clients changed: Instead of taking
`ProviderRequest, ProviderResponse` as generics, they now take
`RpcService`

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.

---------

Co-authored-by: dignifiedquire <[email protected]>
dignifiedquire added a commit to n0-computer/iroh-gossip that referenced this pull request Oct 23, 2024
@Frando @dignifiedquire
feat!: new quic-rpc, simlified generics, bump MSRV to 1.76 (#2268)
77d8a87 
## Description

Adapts iroh for n0-computer/quic-rpc#76

Wit this change, a quic client is
`pub type QuicIroh = Iroh<QuinnConnection<RpcService>>`
instead of
`pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest,
ProviderResponse>>`

## Breaking Changes
* Increased mimimal supported rust version (MSRV) from 1.75 to 1.76
* The generics of the iroh clients changed: Instead of taking
`ProviderRequest, ProviderResponse` as generics, they now take
`RpcService`

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.

---------

Co-authored-by: dignifiedquire <[email protected]>
dignifiedquire added a commit to n0-computer/iroh-docs that referenced this pull request Oct 23, 2024
@Frando @dignifiedquire
feat!: new quic-rpc, simlified generics, bump MSRV to 1.76 (#2268)
9c49883 
## Description

Adapts iroh for n0-computer/quic-rpc#76

Wit this change, a quic client is
`pub type QuicIroh = Iroh<QuinnConnection<RpcService>>`
instead of
`pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest,
ProviderResponse>>`

## Breaking Changes
* Increased mimimal supported rust version (MSRV) from 1.75 to 1.76
* The generics of the iroh clients changed: Instead of taking
`ProviderRequest, ProviderResponse` as generics, they now take
`RpcService`

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.

---------

Co-authored-by: dignifiedquire <[email protected]>
matheus23 pushed a commit to n0-computer/iroh that referenced this pull request Nov 14, 2024
@Frando @dignifiedquire
feat!: new quic-rpc, simlified generics, bump MSRV to 1.76 (#2268)
544280a 
## Description

Adapts iroh for n0-computer/quic-rpc#76

Wit this change, a quic client is
`pub type QuicIroh = Iroh<QuinnConnection<RpcService>>`
instead of
`pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest,
ProviderResponse>>`

## Breaking Changes
* Increased mimimal supported rust version (MSRV) from 1.75 to 1.76
* The generics of the iroh clients changed: Instead of taking
`ProviderRequest, ProviderResponse` as generics, they now take
`RpcService`

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.

---------

Co-authored-by: dignifiedquire <[email protected]>
dignifiedquire added a commit to n0-computer/iroh-metrics that referenced this pull request Dec 2, 2024
@Frando @dignifiedquire
feat!: new quic-rpc, simlified generics, bump MSRV to 1.76 (#2268)
8f279f4 
## Description

Adapts iroh for n0-computer/quic-rpc#76

Wit this change, a quic client is
`pub type QuicIroh = Iroh<QuinnConnection<RpcService>>`
instead of
`pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest,
ProviderResponse>>`

## Breaking Changes
* Increased mimimal supported rust version (MSRV) from 1.75 to 1.76
* The generics of the iroh clients changed: Instead of taking
`ProviderRequest, ProviderResponse` as generics, they now take
`RpcService`

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.

---------

Co-authored-by: dignifiedquire <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rklaehn rklaehn rklaehn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Frando @dignifiedquire @rklaehn