Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Os::SystemResources into CMake Selection #2727

Closed
9 tasks
LeStarch opened this issue May 10, 2024 · 2 comments
Closed
9 tasks

Refactor Os::SystemResources into CMake Selection #2727

LeStarch opened this issue May 10, 2024 · 2 comments
Assignees
@LeStarch
Labels
enhancement
Milestone
Release v3.5.0

Comments

@LeStarch
Copy link
Collaborator

F´ Version
Affected Component

Feature Description

  • Refactor Os::Log into the Interface, Os::Log, and Implementation classes (following pattern of Os::File)
  • Implement Posix implementation
  • Implement Stub implementation
  • Implement Test stub implementation
  • Build common rules-based tests
  • Build specific posix tests
  • Build stub interface tests
  • Setup default posix implementation for Posix platforms
  • Document
@LeStarch LeStarch added this to the Release v3.5.0 milestone May 10, 2024
@LeStarch LeStarch mentioned this issue May 10, 2024
Open
19 tasks
@thomas-bc
Copy link
Collaborator

Note:
-> use singleton pattern in the "face" class (class SystemResources final : public SystemResourcesInterface { to which the static methods delegate to the singleton

@LeStarch LeStarch assigned LeStarch and unassigned kevin-f-ortega Oct 1, 2024
@LeStarch
Copy link
Collaborator Author

LeStarch commented Oct 1, 2024

@kevin-f-ortega reassigning this to me.

@LeStarch LeStarch mentioned this issue Oct 7, 2024
Merged
LeStarch added a commit that referenced this issue Oct 9, 2024
@LeStarch
Issue #2727: Refactor System Resources OSAL Implmentation (#2922)
105cd8e 
* Initial interface, stubs, and stub tests

* Darwin implementation and UTs

* Switching to generic status and usage structures

* Adding string_to_number functions

* Adding linux Cpu and Memory implementations

* Fixing minor test issues

* Linux UTS - WIP

* Fixing issues with linux CPU

* Extending time in lock-guard tester to prevent intermitant failure

* Fixing issue with conversion after check

* Newlines

* Adding config to all modules

* Fixing bad overload

* sp

* Override problem

* Fixing quality check issue

* Touching up template usage for more flexibility

* Fixing bad type comparison

* Review fixes

* Fixing names

* Review fixes pt II

* sp

* Missing header

* Fixing build error

* Conversion issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeStarch LeStarch

Labels
enhancement
Projects
None yet
Milestone
Release v3.5.0
Development

No branches or pull requests
3 participants
@LeStarch @kevin-f-ortega @thomas-bc