-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #2727: Refactor System Resources OSAL Implmentation #2922
Conversation
8095db3
to
67465d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
@thomas-bc will you review? |
@bocchino will you review the use of templates here: fprime/Fw/Types/StringToNumber.cpp Lines 44 to 73 in 296aad0
I can make the argument it is a safe use of templates because: the template is not exposed to users, or outside code (it is implemented in the CPP). The template is used as the implementation of a set of non-templated functions needed by the end user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the template usage. It looks good!
Change Description
Fixes issue #2727 by creating Os::Memory and Os::Cpu interfaces to support the non-filesystem aspects of SystemResources.