-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FPP to v2.1.0a11 #2745
Update FPP to v2.1.0a11 #2745
Conversation
To keep the leak checker happy
CI is complaining because a link in a Markdown file in the cmake docs is unavailable. The issue is unrelated to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, otherwise looks great!
docs/Design/data-products.md
Outdated
@@ -48,7 +51,7 @@ components: | |||
These components produce data products and are typically mission-specific. | |||
For example, they may produce science data. | |||
|
|||
1. Standard F Prime components for managing data products. | |||
1. Standard F' components for managing data products. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should say F´
not F'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I switched all instances of F' to F Prime, which I think is also acceptable. I have some questions about this, which we can resolve offline:
- What is that forward tick character, and how do I type it?
- Since forward tick seems to be a Unicode and not an ASCII character, is there a way to represent it in ASCII? Otherwise a Unicode text editor is required.
- Why are we using forward tick instead of prime ' when we write F'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that if I were writing F' in Markdown as math I would write _F'_
which resolves to F'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rob, I forwarded you an email from Jeff regarding guidance on spelling F Prime, or F´ for short with the prime symbol. This is what we are trying to adhere to. Both F´ or F Prime would work here.
On MacOS, the ´ character can be typed with Option+E.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Note that option-e generates an acute accent, not a prime symbol. There is a Unicode prime symbol, but it looks like it has no shortcut.
Single quote: F'
Prime symbol: Fʹ
Acute accent: F´
CI failure (markdown link not found) was fixed in #2746 and can safely be ignored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ready to merge when we are
FPP Changes