refactored FW_OBJ_NAME, FW_QUEUE_NAME, and FW_TASK_NAME. #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-bc
added
the
Update Instructions Needed
thomas-bc
approved these changes
Jun 3, 2024
|
This looks good! Can we merge #2745 first? Otherwise there is a danger of introducing changes that break FPP v2.1.0a11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
refactored FW_OBJ_NAME_MAX_SIZE, FW_QUEUE_NAME_MAX_SIZE, and FW_TASK_NAME_MAX_SIZE to reflect the new naming of constants to FW_OBJ_NAME_BUFFER_SIZE, FW_QUEUE_NAME_BUFFER_SIZE, and FW_TASK_NAME_BUFFER_SIZE.
Rationale
created more clarity for what the constants represent.
Testing/Review Recommendations
Double-check names as referring to the refactored constants
Future Work
None expected