Only load annotations in fixed time mode or frozen #6866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/03/2023 11:44:03am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 0227ca5 Started: 08/03/2023 11:42:10am UTC Current Playwright Test Results Summary✅ 134 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/03/2023 11:44:03am UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 107 runsfailed over last 7 days |
19.63% (21)21 / 107 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
2.22% (3)3 / 135 runsfailed over last 7 days |
23.70% (32)32 / 135 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6866 +/- ##
==========================================
+ Coverage 48.26% 48.38% +0.12%
==========================================
Files 644 644
Lines 25636 25628 -8
Branches 2499 2496 -3
==========================================
+ Hits 12373 12400 +27
+ Misses 12787 12751 -36
- Partials 476 477 +1
*This pull request uses carry forward flags. Click here to find out more.
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
scottbell
requested review from
ozyx and
jvigliotta
and removed request for
jvigliotta
…ding-annotations-to-a-plot
scottbell
changed the title
…ons-to-a-plot' of github.com:nasa/openmct into 6822-major-performance-degradation-when-adding-annotations-to-a-plot
scottbell
added
pr:e2e:couchdb
…ding-annotations-to-a-plot
…ding-annotations-to-a-plot
ozyx
approved these changes
Aug 3, 2023
| @@ -94,6 +98,13 @@ async function createDomainObjectWithDefaults(page, { type, name, parent = 'mine | |||
| await notesInput.fill(page.testNotes); | |||
| } | |||
|
|
|||
| // If there are any further parameters, fill them in | |||
| for (const [key, value] of Object.entries(customParameters)) { | |||
ozyx
deleted the
6822-major-performance-degradation-when-adding-annotations-to-a-plot
branch
|
Created #6893 to also backmerge this into 3.0.1 |
scottbell
added a commit
that referenced
this pull request
Aug 8, 2023
* fix annotations load to not happen on start * remove range checking per annotated point * back to local variable * reduce tagging size to improve reliability of test * remove .only * remove .only * reduce hz rate for functional test and keep high frequency test in performance * remove console.debugs * this test runs pretty fast now * fix network request tests to match new behavior
ozyx
pushed a commit
that referenced
this pull request
Aug 8, 2023
#6902) Only load annotations in fixed time mode or frozen (#6866) * fix annotations load to not happen on start * remove range checking per annotated point * back to local variable * reduce tagging size to improve reliability of test * remove .only * remove .only * reduce hz rate for functional test and keep high frequency test in performance * remove console.debugs * this test runs pretty fast now * fix network request tests to match new behavior
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6822
Describe your changes:
Only load annotations if in fixed time mode or frozen.
All Submissions:
Author Checklist
Reviewer Checklist