Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#6866): Only load annotations in fixed time mode or frozen #6902

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Aug 8, 2023

Closes #6893
Relates to #6822

Describe your changes:

Cherry picks commit from master in 3.0.1 branch

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

* fix annotations load to not happen on start

* remove range checking per annotated point

* back to local variable

* reduce tagging size to improve reliability of test

* remove .only

* remove .only

* reduce hz rate for functional test and keep high frequency test in performance

* remove console.debugs

* this test runs pretty fast now

* fix network request tests to match new behavior
@scottbell scottbell requested a review from ozyx August 8, 2023 07:37
@deploysentinel
Copy link

deploysentinel bot commented Aug 8, 2023

Current Playwright Test Results Summary

✅ 134 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/08/2023 08:52:05am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 8824df2

Started: 08/08/2023 08:44:58am UTC

⚠️ Flakes

📄   functional/plugins/plot/tagging.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Plot Tagging Tags work with Overlay Plots
Retry 2Retry 1Initial Attempt
15.91% (7) 7 / 44 runs
failed over last 7 days
20.45% (9) 9 / 44 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use independent time conductor to change time
Retry 2Retry 1Initial Attempt
25.88% (22) 22 / 85 runs
failed over last 7 days
22.35% (19) 19 / 85 runs
flaked over last 7 days
Example Imagery in Display Layout View Large action pauses imagery when in realtime and returns to realtime
Retry 1Initial Attempt
0% (0) 0 / 81 runs
failed over last 7 days
2.47% (2) 2 / 81 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/08/2023 08:52:05am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 8824df2

Started: 08/08/2023 07:40:32am UTC

View Detailed Build Results


@scottbell scottbell linked an issue Aug 8, 2023 that may be closed by this pull request
@ozyx ozyx changed the title Back merge fix to only show annotations in fixed mode into 3.0.1 cherry-pick(#6866): Only load annotations in fixed time mode or frozen Aug 8, 2023
@ozyx ozyx added this to the Target:3.0.1 milestone Aug 8, 2023
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozyx ozyx merged commit 32b68cf into release/3.0.1 Aug 8, 2023
@ozyx ozyx deleted the 6893-back-merge-fix-to-only-show-annotations-in-fixed-mode-into-301-real branch August 8, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

back-merge fix to only show annotations in fixed mode into 3.0.1
2 participants