Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timers] Throttle refresh calls #6882

Closed
wants to merge 3 commits into from
Closed

[Timers] Throttle refresh calls #6882

wants to merge 3 commits into from

Conversation

jvigliotta
Copy link
Contributor

Closes #6880

Describe your changes:

Turns out... that refresh was needed! This is for multi-user timer use. Have added the refresh back in and have throttled it to 2 seconds with a new throttle util (looking to get away from lodash, no offense to lodash).

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Aug 2, 2023

Current Playwright Test Results Summary

✅ 130 Passing - ❌ 1 Failing - ⚠️ 7 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/02/2023 09:50:53pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: de5914b

Started: 08/02/2023 09:42:10pm UTC

❌ Failures

📄   functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 2Retry 1Initial Attempt
Error: expect(received).toHaveText(expected)...
expect(received).toHaveText(expected)

Expected string: "---"
Received string: "false"
Call log:
  - expect.toHaveText with timeout 5000ms
  - waiting for locator('[aria-label="Current Output Value"]')
  -   locator resolved to <span aria-label="Current Output Value" class="c-cs__c…>Default</span>
  -   unexpected value "Default"
  - waiting for locator('[aria-label="Current Output Value"]')
  -   locator resolved to <span aria-label="Current Output Value" class="c-cs__c…>Default</span>
  -   unexpected value "Default"
  -   locator resolved to <span aria-label="Current Output Value" class="c-cs__c…>Default</span>
  -   unexpected value "Default"
  -   locator resolved to <span aria-label="Current Output Value" class="c-cs__c…>Default</span>
  -   unexpected value "Default"
  -   locator resolved to <span aria-label="Current Output Value" class="c-cs__c…>Default</span>
  -   unexpected value "Default"
  -   locator resolved to <span aria-label="Current Output Value" class="c-cs__c…>false</span>
  -   unexpected value "false"
  -   locator resolved to <span aria-label="Current Output Value" class="c-cs__c…>false</span>
  -   unexpected value "false"
  -   locator resolved to <span aria-label="Current Output Value" class="c-cs__c…>false</span>
  -   unexpected value "false"
  -   locator resolved to <span aria-label="Current Output Value" class="c-cs__c…>false</span>
  -   unexpected value "false"

10% (12) 12 / 120 runs
failed over last 7 days
38.33% (46) 46 / 120 runs
flaked over last 7 days

⚠️ Flakes

📄   functional/plugins/plot/autoscale.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Autoscale User can set autoscale with a valid range @snapshot
Retry 2Retry 1Initial Attempt
19.44% (21) 21 / 108 runs
failed over last 7 days
22.22% (24) 24 / 108 runs
flaked over last 7 days

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
2.80% (3) 3 / 107 runs
failed over last 7 days
14.02% (15) 15 / 107 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 106 runs
failed over last 7 days
19.81% (21) 21 / 106 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 106 runs
failed over last 7 days
19.81% (21) 21 / 106 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
2.24% (3) 3 / 134 runs
failed over last 7 days
21.64% (29) 29 / 134 runs
flaked over last 7 days

📄   functional/plugins/flexibleLayout/flexibleLayout.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Flexible Layout independent time works with flexible layouts and its children
Retry 2Retry 1Initial Attempt
6.09% (7) 7 / 115 runs
failed over last 7 days
3.48% (4) 4 / 115 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use independent time conductor to change time
Retry 1Initial Attempt
20.18% (22) 22 / 109 runs
failed over last 7 days
19.27% (21) 21 / 109 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #6882 (de5914b) into master (95e6860) will increase coverage by 0.79%.
Report is 2 commits behind head on master.
The diff coverage is 68.18%.

@@            Coverage Diff             @@
##           master    #6882      +/-   ##
==========================================
+ Coverage   46.92%   47.71%   +0.79%     
==========================================
  Files         643      644       +1     
  Lines       25622    25645      +23     
  Branches     2505     2506       +1     
==========================================
+ Hits        12023    12237     +214     
+ Misses      13125    12931     -194     
- Partials      474      477       +3     
Flag Coverage Δ *Carryforward flag
e2e-full 41.99% <ø> (ø) Carriedforward from 41bbbb1
e2e-stable 52.94% <88.23%> (-0.12%) ⬇️
unit 38.70% <0.00%> (-0.08%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
src/plugins/timer/components/Timer.vue 4.04% <0.00%> (+0.81%) ⬆️
src/utils/throttle.js 87.50% <87.50%> (ø)
src/plugins/timer/TimerViewProvider.js 80.00% <100.00%> (-20.00%) ⬇️

... and 69 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e6860...de5914b. Read the comment docs.

@jvigliotta jvigliotta requested a review from akhenry August 2, 2023 16:49
@jvigliotta jvigliotta changed the title created a throttle util and using it in timer plugin to throttle refr… [Timers] Throttle refresh calls Aug 2, 2023
@ozyx ozyx added this to the Target:3.0.0 milestone Aug 2, 2023
@akhenry
Copy link
Contributor

akhenry commented Aug 2, 2023

Closed in favor of #6885

@ozyx ozyx closed this Aug 2, 2023
@ozyx ozyx deleted the multi-user-timer branch August 13, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in timer state are not observed by other users
3 participants