-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Timers] Throttle refresh calls #6882
Conversation
…eshing the timer domain object
Current Playwright Test Results Summary✅ 130 Passing - ❌ 1 Failing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/02/2023 09:50:53pm UTC) ❌ Failures📄 functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 FailureTest Case Results
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Autoscale User can set autoscale with a valid range @snapshot
Retry 2 • Retry 1 • Initial Attempt |
19.44% (21)21 / 108 runsfailed over last 7 days |
22.22% (24)24 / 108 runsflaked over last 7 days |
📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
2.80% (3)3 / 107 runsfailed over last 7 days |
14.02% (15)15 / 107 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 106 runsfailed over last 7 days |
19.81% (21)21 / 106 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 106 runsfailed over last 7 days |
19.81% (21)21 / 106 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
2.24% (3)3 / 134 runsfailed over last 7 days |
21.64% (29)29 / 134 runsflaked over last 7 days |
📄 functional/plugins/flexibleLayout/flexibleLayout.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Flexible Layout independent time works with flexible layouts and its children
Retry 2 • Retry 1 • Initial Attempt |
6.09% (7)7 / 115 runsfailed over last 7 days |
3.48% (4)4 / 115 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Example Imagery Object Can use independent time conductor to change time
Retry 1 • Initial Attempt |
20.18% (22)22 / 109 runsfailed over last 7 days |
19.27% (21)21 / 109 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6882 +/- ##
==========================================
+ Coverage 46.92% 47.71% +0.79%
==========================================
Files 643 644 +1
Lines 25622 25645 +23
Branches 2505 2506 +1
==========================================
+ Hits 12023 12237 +214
+ Misses 13125 12931 -194
- Partials 474 477 +3
*This pull request uses carry forward flags. Click here to find out more.
... and 69 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Closed in favor of #6885 |
Closes #6880
Describe your changes:
Turns out... that refresh was needed! This is for multi-user timer use. Have added the refresh back in and have throttled it to 2 seconds with a new throttle util (looking to get away from lodash, no offense to lodash).All Submissions:
Author Checklist
Reviewer Checklist