-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize timers between multiple users #6885
Conversation
…eshing the timer domain object
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/02/2023 11:20:26pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 6358b9c Started: 08/02/2023 11:17:36pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 1 • Initial Attempt |
9.84% (6)6 / 61 runsfailed over last 7 days |
19.67% (12)12 / 61 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 131 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 08/02/2023 11:20:26pm UTC)
⚠️ Flakes
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
2.16% (3)3 / 139 runsfailed over last 7 days |
21.58% (30)30 / 139 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6885 +/- ##
==========================================
- Coverage 48.27% 48.25% -0.03%
==========================================
Files 643 644 +1
Lines 25629 25636 +7
Branches 2505 2499 -6
==========================================
- Hits 12373 12371 -2
- Misses 12783 12789 +6
- Partials 473 476 +3
*This pull request uses carry forward flags. Click here to find out more.
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
* created a throttle util and using it in timer plugin to throttle refreshing the timer domain object * Simplify timer logic * Clarify code a little * refactor: lint:fix * Fix linting issue --------- Co-authored-by: Jamie V <[email protected]> Co-authored-by: Jesse Mazzella <[email protected]> Co-authored-by: Jesse Mazzella <[email protected]>
* created a throttle util and using it in timer plugin to throttle refreshing the timer domain object * Simplify timer logic * Clarify code a little * refactor: lint:fix * Fix linting issue --------- Co-authored-by: Andrew Henry <[email protected]> Co-authored-by: Jamie V <[email protected]>
Closes #6880
Describe your changes:
Thanks to @jvigliotta and @ozyx for doing most of the work here, allowing me to swoop in and claim the credit.
*
listener. This is gross, but I think we were hitting an issue with properties on proxied objects being replaced with non-proxied versions when a refresh happensAll Submissions:
Author Checklist
Reviewer Checklist