This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
extension to enable/disable remote signals #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raalsky
reviewed
Oct 30, 2023
| @@ -18,16 +18,51 @@ | |||
| from typing import Any | |||
There was a problem hiding this comment.
We have CHANGELOG here as well :D. You can just copy-paste what we had earlier in regular package
There was a problem hiding this comment.
My bad, on it! :D
Raalsky
reviewed
Oct 30, 2023
|
|
||
| super().__init__(*args, **kwargs) | ||
|
|
||
| def _prepare_background_jobs(self) -> BackgroundJobList: |
There was a problem hiding this comment.
We're probably able to get rid of this duplicated logic with calling the parent _prepare_background_jobs and filtering out the WebsocketsSignalsBackgroundJob? What do you think?
Raalsky
approved these changes
Oct 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests should start passing after the revert of this feature is on
neptune-clientmasterbranchEDIT: Done