This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
extension to enable/disable remote signals #2
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,16 +18,34 @@ | |
from typing import Any | ||
|
||
import neptune | ||
from neptune.internal.backgroud_job_list import BackgroundJobList | ||
from neptune.internal.utils import verify_type | ||
from neptune.internal.websockets.websocket_signals_background_job import WebsocketSignalsBackgroundJob | ||
|
||
|
||
# That's just a boilerplate code to make sure that the extension is loaded | ||
class CustomRun(neptune.Run): | ||
def __init__(self, *args: Any, **kwargs: Any) -> None: | ||
print("That's custom class") | ||
enable_remote_signals = kwargs.pop("enable_remote_signals", None) | ||
|
||
kwargs["capture_hardware_metrics"] = False | ||
kwargs["capture_stdout"] = False | ||
kwargs["capture_stderr"] = False | ||
kwargs["capture_traceback"] = False | ||
if enable_remote_signals is None: | ||
self._enable_remote_signals = True # user did not pass this param in kwargs -> default value | ||
else: | ||
|
||
verify_type("enable_remote_signals", enable_remote_signals, bool) | ||
self._enable_remote_signals = enable_remote_signals | ||
|
||
super().__init__(*args, **kwargs) | ||
|
||
def _prepare_background_jobs(self) -> BackgroundJobList: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We're probably able to get rid of this duplicated logic with calling the parent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
background_jobs = super()._prepare_background_jobs() | ||
|
||
if not self._enable_remote_signals: | ||
# filter-out websocket job | ||
background_jobs._jobs = list( | ||
filter( | ||
lambda x: not isinstance(x, WebsocketSignalsBackgroundJob), | ||
background_jobs._jobs, | ||
) | ||
) | ||
|
||
return background_jobs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have CHANGELOG here as well :D. You can just copy-paste what we had earlier in regular package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, on it! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done