Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: drop hostname option from all profiles #5702

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

glitsj16
Copy link
Collaborator

@glitsj16 glitsj16 commented Mar 1, 2023

Now we have randomized UTS namespaces support by default for every sandbox there's no longer a need to set hostname to a fixed value. This PR removes such fixed hostname entrees from all profiles that had it.

@glitsj16
Copy link
Collaborator Author

glitsj16 commented Mar 1, 2023

@kmk3 I opened this PR as a draft because it could relate to #5645. If that's incorrect or not necessary, please let me know so I can change the status.

@netblue30
Copy link
Owner

This one should go in regardless of #5645 - anyway, I think I'll close #5645, all seems to be fine so far.

@glitsj16 glitsj16 marked this pull request as ready for review March 13, 2023 18:29
@glitsj16
Copy link
Collaborator Author

This one should go in regardless of #5645...

@netblue30 Marked it 'ready for review' so feel free to proceed.

Now that we have randomized UTS namespaces support[1] by default for
every sandbox, there's no longer a need to set hostname to a fixed
value.  This commit removes such fixed hostname entries from all
profiles that have it.

[1] netblue30#5597 (comment)
@kmk3
Copy link
Collaborator

kmk3 commented Mar 14, 2023

(Force-pushed for squashing)

@netblue30 on Mar 13:

This one should go in regardless of #5645

Yes, I don't think that this would conflict with #5645.

anyway, I think I'll close #5645, all seems to be fine so far.

The main issues still remain AFAIK; I'll expand on them on #5645 later.

@glitsj16 glitsj16 merged commit 35c9f1f into netblue30:master Mar 14, 2023
@glitsj16 glitsj16 deleted the hostname-fixes branch March 14, 2023 23:17
@kmk3 kmk3 changed the title Drop hostname option from all profiles profiles: drop hostname option from all profiles Mar 25, 2024
kmk3 added a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

3 participants