profiles: improvements to profiles using private #5946
Conversation
|
TBH we should fix #903 instead of adding references to profiles. |
There was a problem hiding this comment.
As mentioned here, I think it would make more sense to remove private
for profiles that use paths in ${HOME}.
Also, I'd use # instead of - for comments at the end of the line, to avoid
a syntax error if uncommenting the line (see also #5942).
For the other profiles, if including whitelist-common.inc helps a given
profile, why not drop private? And if it doesn't, why not simply remove it?
They seem to be made for different use cases AFAICT (need to access some vs no
files in the real ${HOME}).
|
@kmk3 Thanks for the argumentation. Looks better now. |
Changes:
* comment `include whitelist-common.inc` when using `private`
* drop `private` on profiles that access files in `${HOME}`
* use `#` in comments
Relates to netblue30#903.
kmk3
force-pushed
the
private-whitelisting
branch
from
f621e1f to
eab608f
Compare
kmk3
changed the title
|
Note: I'm not sure what the intended behavior would be (copy vs bind-mount) if |
As I was recently reminded by @kmk3 to #903 I checked existing profiles for similar issues. This PR fixes whitelisting in ${HOME} and streamlines the reference to #903.