Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enable compiler warnings by default #5842

Merged
merged 2 commits into from
May 31, 2023
Merged

build: enable compiler warnings by default #5842

merged 2 commits into from
May 31, 2023

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented May 31, 2023

Enable -Wall by default and add -Wextra.

glitsj16
glitsj16 approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netblue30 netblue30 merged commit 30ff544 into netblue30:master May 31, 2023
@netblue30
Copy link
Owner

Let's try it out, thanks!

@kmk3 kmk3 deleted the build-enable-warnings branch June 1, 2023 11:23
kmk3 added a commit that referenced this pull request Jun 19, 2023
@kmk3
RELNOTES: add build, ci and contrib items
d288a53 
Relates to #5842 #5850 #5857.
@kmk3 kmk3 added the enhancement New feature request label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glitsj16 glitsj16 glitsj16 approved these changes

Assignees
No one assigned
Labels
enhancement New feature request
Projects
Release 0.9.74
Status: Done (on RELNOTES)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmk3 @netblue30 @glitsj16