contrib/vim: match profile files more broadly #5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmk3
force-pushed
the
vim-improve-ftdetect
branch
2 times, most recently
from
5ec6ecf to
2576ccd
Compare
Currently it only sets the appropriate filetype for files in `/etc/firejail` and `~/.config/firejail`. With this commit, the firejail filetype should also be set when opening `etc/inc/*.inc`, for example, as long as there is a "firejail" directory somewhere before that (such as in `/foo/firejail/bar/etc/inc/*.inc`). Note: At least `*/firejail/*.inc` needs to force the match (by using `set filetype` rather than `setfiletype`), or else the default vim checks take precedence (and the filetype for all files in `etc/inc/*.inc` gets set to `pov`). Fixes netblue30#4319. Relates to netblue30#2679. Co-authored-by: rusty-snake <[email protected]>
kmk3
force-pushed
the
vim-improve-ftdetect
branch
from
2576ccd to
6273865
Compare
rusty-snake
approved these changes
Jun 11, 2023
kmk3
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it only sets the appropriate filetype for files in
/etc/firejailand~/.config/firejail.With this commit, the firejail filetype should also be set when opening
etc/inc/*.inc, for example, as long as there is a "firejail" directorysomewhere before that (such as in
/foo/firejail/bar/etc/inc/*.inc).Note: At least
*/firejail/*.incneeds to force the match (by usingset filetyperather thansetfiletype), or else the default vimchecks take precedence (and the filetype for all files in
etc/inc/*.incgets set topov).Fixes #4319.
Relates to #2679.
Cc: @laomaiweng @reinerh @rusty-snake (from #2679 #4319)