Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: wget: allow ~/.local/share/wget #6542

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

celenityy
Copy link
Contributor

@celenityy celenityy commented Nov 11, 2024

wget appears to require access to this directory for HSTS & HPKP.

Without access to this directory, I get the following error when running wget:

Failed to read HSTS data
Failed to read HPKP data
Failed to write HSTS file

This fixes it.

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Distributions started to replace wget with wget2 (I.e. wget and wget2 are the same binary where one of them is a symlink to the other).

We should reorganize our profile for this fact.

Can you also add .config/wget and remove the then doubled noblacklists from wget2.profile.

wget appears to require access to this directory for HSTS & HPKP.

Without access to this directory, I get the following error when running
wget:

    Failed to read HSTS data
    Failed to read HPKP data
    Failed to write HSTS file

This fixes it.
@kmk3
Copy link
Collaborator

kmk3 commented Nov 19, 2024

@rusty-snake

Distributions started to replace wget with wget2 (I.e. wget and wget2 are
the same binary where one of them is a symlink to the other).

Good catch.

We should reorganize our profile for this fact.

Can you also add .config/wget and remove the then doubled noblacklists from
wget2.profile.

Since this is a self-contained fix, how about merging this as is and then I
open a PR to refactor them after this PR?

@kmk3 kmk3 requested a review from rusty-snake November 19, 2024 22:22
Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a self-contained fix, how about merging this as is and then I
open a PR to refactor them after this PR?

If you do, I approve.

@kmk3 kmk3 merged commit 66a2818 into netblue30:master Nov 24, 2024
3 checks passed
kmk3 added a commit to kmk3/firejail that referenced this pull request Nov 24, 2024
According to @rusty-snake[1]:

> Distributions started to replace wget with wget2 (I.e. `wget` and
> `wget2` are the same binary where one of them is a symlink to the
> other).

So move all custom entries (other than `private-bin`) from wget2.profile
into wget.profile and turn wget2.profile into more of a redirect to
wget.profile.

[1] netblue30#6542 (review)
kmk3 added a commit to kmk3/firejail that referenced this pull request Nov 25, 2024
According to @rusty-snake[1]:

> Distributions started to replace wget with wget2 (I.e. `wget` and
> `wget2` are the same binary where one of them is a symlink to the
> other).

So move all custom entries (other than `private-bin`) from wget2.profile
into wget.profile and turn wget2.profile into more of a redirect to
wget.profile.

[1] netblue30#6542 (review)
kmk3 added a commit that referenced this pull request Nov 25, 2024
According to @rusty-snake[1]:

> Distributions started to replace wget with wget2 (I.e. `wget` and
> `wget2` are the same binary where one of them is a symlink to the
> other).

So move all custom entries (other than `private-bin`) from wget2.profile
into wget.profile and turn wget2.profile into more of a redirect to
wget.profile.

[1] #6542 (review)
kmk3 added a commit that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

3 participants