profiles: ensure allow-lua where mpv is allowed #6555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpv crashes if luajit is blocked:
$ firejail --quiet --noprofile \
--include=/etc/firejail/disable-interpreters.inc /usr/bin/mpv
/usr/bin/mpv: error while loading shared libraries: libluajit-5.1.so.2: cannot open shared object file: Permission denied
So make sure that allow-lua.inc is always included when mpv paths (such
as ~/.config/mpv) are allowed.
Environment: luajit 2.1.1727870382-1, mpv 1:0.39.0-3 on Artix Linux.
Related commits:
* db2bdaa ("add lua support for mpv (netblue30#3243)", 2020-02-24) /
PR netblue30#3243
* d6a6fb9 ("Allow Lua for mpv in dolphin.profile", 2020-04-18) /
issue netblue30#3363
* f3585e5 ("fixes, closes, enhances, improvements, and so on",
2020-11-09) /
issue netblue30#3686
* 3ec523f ("profiles: anki: allow lua", 2024-11-14) /
PR netblue30#6545
kmk3
added a commit
that referenced
this pull request
Nov 29, 2024
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Nov 30, 2024
Add missing paths for: * lua (for mpv) * mplayer * mpv * smplayer * vlc Apparently mpv plugins may break without the lua path; see commit ccff014 ("fix Lua in mpv.profile", 2020-07-28) / issue netblue30#3554. Command used to search for relevant profiles: $ git grep -IE -l '/\.?(s?mplayer|mpv|vlc)' -- etc This is a follow-up to commit e4ebbfa ("profiles: ensure allow-lua where mpv is allowed (netblue30#6555)", 2024-11-29).
kmk3
added a commit
that referenced
this pull request
Dec 9, 2024
Add missing paths for: * lua (for mpv) * mplayer * mpv * smplayer * vlc Apparently mpv plugins may break without the lua path; see commit ccff014 ("fix Lua in mpv.profile", 2020-07-28) / issue #3554. Command used to search for relevant profiles: $ git grep -IE -l '/\.?(s?mplayer|mpv|vlc)' -- etc This is a follow-up to commit e4ebbfa ("profiles: ensure allow-lua where mpv is allowed (#6555)", 2024-11-29).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpv crashes if luajit is blocked:
So make sure that allow-lua.inc is always included when mpv paths (such
as ~/.config/mpv) are allowed.
Environment: luajit 2.1.1727870382-1, mpv 1:0.39.0-3 on Artix Linux.
Related commits:
PR profiles: mpv: allow lua #3243
issue dolphin: allow lua for playing videos with mpv #3363
2020-11-09) /
issue mpsyt: mpv needs lua #3686
PR profiles: anki: fix opening, allow media & add to firecfg #6545