Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: rename print-version target to installcheck #6620

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Jan 16, 2025

To make it consistent with the standard GNU make targets.

From the manual of GNU Make (version 4.4.1-2):

'installcheck'
Perform installation tests (if any). The user must build and
install the program before running the tests. You should not
assume that '$(bindir)' is in the search path.

Commands used to search and replace:

$ git grep -Ilz print-version |
  xargs -0 -I '{}' sh -c "printf '%s\n' \"\$(sed \
    's/print-version/installcheck/g' '{}')\" >'{}'"
$ git grep -Ilz 'print version' .github/workflows |
  xargs -0 -I '{}' sh -c "printf '%s\n' \"\$(sed \
    's/print version/make installcheck/g' '{}')\" >'{}'"

Added on commit c9531d9 ("build: add print-version target and use in
CI", 2024-02-22) / #6230.

To make it consistent with the standard GNU make targets.

From the manual of GNU Make (version 4.4.1-2):

> 'installcheck'
>      Perform installation tests (if any).  The user must build and
>      install the program before running the tests.  You should not
>      assume that '$(bindir)' is in the search path.

Commands used to search and replace:

    $ git grep -Ilz print-version |
      xargs -0 -I '{}' sh -c "printf '%s\n' \"\$(sed \
        's/print-version/installcheck/g' '{}')\" >'{}'"
    $ git grep -Ilz 'print version' .github/workflows |
      xargs -0 -I '{}' sh -c "printf '%s\n' \"\$(sed \
        's/print version/make installcheck/g' '{}')\" >'{}'"

Added on commit c9531d9 ("build: add print-version target and use in
CI", 2024-02-22) / netblue30#6230.
@kmk3 kmk3 force-pushed the build-rename-print-version branch from 95eac99 to 584950c Compare January 16, 2025 20:38
@kmk3 kmk3 merged commit 1a576d1 into netblue30:master Jan 18, 2025
13 checks passed
@kmk3 kmk3 deleted the build-rename-print-version branch January 18, 2025 04:48
@kmk3 kmk3 added the modif This modifies existing behavior label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modif This modifies existing behavior
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

1 participant