Fix how NODE_ENV is being handled #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an specific NODE_ENV value is specified, let it pass through and set the mode accordingly. If a non-standard NODE_ENV is specified, let is pass through and set the webpack mode to none.
|
hmm, i like the turning off of optimization for dev. cheers! |
|
Could we please get a new release of this library so that this PR is included? Thanks! |
|
sure jesse. been a while |
This was referenced Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #119
If a standard NODE_ENV value is specified (production or development), let it pass through and set the mode accordingly. If a non-standard NODE_ENV is specified, let is pass through and set the Webpack mode to none.