Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how NODE_ENV is being handled #123

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Fix how NODE_ENV is being handled #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,14 @@ function webpackConfig(dir, additionalConfig) {
defineEnv['process.env.' + key] = JSON.stringify(envConfig[key]);
});

// Keep the same NODE_ENV if it was specified
var nodeEnv = process.env.NODE_ENV || 'production'

// Set webpack mode based on the nodeEnv
var webpackMode = ['production', 'development'].includes(nodeEnv) ? nodeEnv : 'none'

var webpackConfig = {
mode: 'production',
mode: webpackMode,
resolve: {
extensions: ['.wasm', '.mjs', '.js', '.json', '.ts']
},
Expand Down Expand Up @@ -99,6 +105,9 @@ function webpackConfig(dir, additionalConfig) {
filename: '[name].js',
libraryTarget: 'commonjs'
},
optimization: {
nodeEnv
},
devtool: false
};
fs.readdirSync(dirPath).forEach(function(file) {
Expand Down