Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP8.3 support #8981

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add PHP8.3 support #8981

merged 1 commit into from
Oct 20, 2023

Conversation

JohannesGGE
Copy link
Contributor

@JohannesGGE JohannesGGE commented Oct 20, 2023 •
edited
Loading

Fix: #8918

@JohannesGGE JohannesGGE self-assigned this Oct 20, 2023
ChristophWurst
ChristophWurst reviewed Oct 20, 2023
View reviewed changes
composer.lock Outdated Show resolved Hide resolved
JohannesGGE
JohannesGGE commented Oct 20, 2023
View reviewed changes
.github/workflows/test.yml
Comment on lines +75 to +78
- php-versions: 8.3
nextcloud-versions: master
db: 'mysql'
cache: 'nocache'
Copy link
Contributor Author

@JohannesGGE JohannesGGE Oct 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why test on master is just for 8.0.
Is the 8.3 test for master sufficient?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We don't need to test all possible combinations. It's sufficient if we have each PHP/DB/server covered at least once

@JohannesGGE JohannesGGE marked this pull request as ready for review October 20, 2023 13:17
@JohannesGGE
Add PHP8.3 support
bcc3739 
Signed-off-by: Johannes Merkel <[email protected]>
@ChristophWurst ChristophWurst merged commit 63dfc59 into main Oct 20, 2023
32 checks passed
@ChristophWurst ChristophWurst deleted the feat/php8.3-support branch October 20, 2023 16:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees

@JohannesGGE JohannesGGE

Labels
3. to review feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PHP8.3 support
2 participants
@JohannesGGE @ChristophWurst