Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP8.3 support #8981

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add PHP8.3 support #8981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint-php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: [ "8.0", "8.1", "8.2" ]
php-versions: [ "8.0", "8.1", "8.2", "8.3" ]

name: php-lint

Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ['8.0', '8.1', '8.2']
php-versions: ['8.0', '8.1', '8.2', '8.3']
nextcloud-versions: ['master']
include:
- php-versions: '8.1'
Expand Down Expand Up @@ -72,6 +72,10 @@ jobs:
nextcloud-versions: stable27
db: 'sqlite'
cache: 'redis'
- php-versions: 8.3
nextcloud-versions: master
db: 'mysql'
cache: 'nocache'
Comment on lines +75 to +78
Copy link
Contributor Author

@JohannesGGE JohannesGGE Oct 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why test on master is just for 8.0.
Is the 8.3 test for master sufficient?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We don't need to test all possible combinations. It's sufficient if we have each PHP/DB/server covered at least once

name: ${{ matrix.nextcloud-versions }} w/ php${{ matrix.php-versions }}-${{ matrix.db }}-${{ matrix.cache }} integration tests
services:
mail-service:
Expand Down
2 changes: 1 addition & 1 deletion appinfo/info.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Learn more about the Nextcloud Ethical AI Rating [in our blog](https://nextcloud
<repository type="git">https://github.com/nextcloud/mail.git</repository>
<screenshot>https://user-images.githubusercontent.com/12728974/266270227-86b99bbb-03ea-468b-8408-e248e1730bed.png</screenshot>
<dependencies>
<php min-version="8.0" max-version="8.2" />
<php min-version="8.0" max-version="8.3" />
<nextcloud min-version="26" max-version="28" />
</dependencies>
<background-jobs>
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"autoloader-suffix": "Mail"
},
"require": {
"php": ">=8.0 <=8.2",
"php": ">=8.0 <=8.3",
"ext-openssl": "*",
"arthurhoaro/favicon": "^1.3.3",
"bamarni/composer-bin-plugin": "^1.8.2",
Expand Down
6 changes: 3 additions & 3 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading