Use app.json, upgrade to heroku-22
#1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created from an existing review app's https://dashboard.heroku.com/apps/auspice-docs-fixes-axgtobmfios/app-json - Removed review-app-specific HEROKU_* vars - Set non-secrets HOST and NPM_CONFIG_PRODUCTION values directly in the file
Previously, these values were just set in the Heroku dashboard. Adding some useful context now that they are in app.json.
heroku-18 is deprecated and Heroku has been persistent with reminders to upgrade. https://help.heroku.com/X5OE6BCA/heroku-18-end-of-life-faq
|
Failing RTD build is unrelated: nextstrain/ncov#982 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(same thing as nextstrain/auspice.us#33 for this repo)
Description of proposed changes
Create an app.json and use it to upgrade the Heroku stack to
heroku-22.Related issue(s)
N/A
Testing
heroku-22