Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argparse: Restore --help and --help-all difference on Python ≥3.10 #259

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented Feb 27, 2023

The section heading used in argparse's formatted help output changed in 3.10¹, rendering --help equivalent to --help-all. This affected anyone with Nextstrain CLI installed on Python 3.10 or newer, including our standalone installation binaries.

¹ python/cpython#23858
https://bugs.python.org/issue9694

Testing

  • Broken functionality on local dev env is fixed by this
  • Standalone build produced by CI is fixed by this
  • Checks pass

The section heading used in argparse's formatted help output changed in
3.10¹, rendering --help equivalent to --help-all.  This affected anyone
with Nextstrain CLI installed on Python 3.10 or newer, including our
standalone installation binaries.

¹ <python/cpython#23858>
  <https://bugs.python.org/issue9694>
@tsibley tsibley force-pushed the trs/fix-help-all-on-≥3.10 branch from f2caa4c to ee4f170 Compare February 28, 2023 18:26
@tsibley tsibley requested a review from a team February 28, 2023 18:27
@tsibley tsibley merged commit b6596a2 into master Feb 28, 2023
@tsibley tsibley deleted the trs/fix-help-all-on-≥3.10 branch February 28, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants