Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid fsspec/s3fs 2023.9.1 due to errors caused by auto_mkdir #313

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

joverlee521
Copy link
Contributor

@joverlee521 joverlee521 commented Sep 18, 2023

Description of proposed changes

Changes to the auto_mkdir parameter in fsspec/filesystem_spec#1358 leads to the error described in fsspec/s3fs#790.

Upstream fixes to come soon via fsspec/filesystem_spec#1365 but good to avoid versions that we know are broken.

Checklist

  • Checks pass

Changes to the `auto_mkdir` parameter in fsspec/filesystem_spec#1358
leads to the error described in fsspec/s3fs#790.

Upstream fixes to come soon via fsspec/filesystem_spec#1365
but good to avoid versions that we know are broken.
@joverlee521
Copy link
Contributor Author

Release with this change will fix our currently blocked automated AWS Batch builds that use the setup-nextstrain-cli action, which still installs the Nextstrain CLI via pip.

@joverlee521 joverlee521 requested a review from a team September 18, 2023 22:36
Copy link
Member

@tsibley tsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by inspection. Both the built wheel and standalone archive from the CI run get the expected fsspec/s3fs version for me locally and successfully submit AWS Batch jobs instead of being broken.

@tsibley
Copy link
Member

tsibley commented Sep 18, 2023

Ah, a brief changelog entry noting avoidance of a compatibility issue would be good.

@joverlee521 joverlee521 merged commit e03b2b7 into master Sep 18, 2023
@joverlee521 joverlee521 deleted the avoid-fsspec-2023.9.1 branch September 18, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants