Check if Rosetta 2 is enabled in the Conda and Docker runner checks #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When on macOS on aarch64 hardware, the Conda runtime currently requires Rosetta. The Docker runtime does not require it, but can benefit from it because our aarch64 image isn't totally free of x86_64 code (yet?), so emulation is required and Rosetta is faster than QEMU. The standalone installer still checks for Rosetta as we previously didn't produce aarch64 standalone binaries¹, but that check will be made conditional on Nextstrain CLI version in a subsequent commit² after the first release of aarch64 support and these new Rosetta checks. ¹ <#357> ² <#358>
tsibley
added a commit
that referenced
this pull request
Feb 2, 2024
Conditions on the Nextstrain CLI version being requested, as aarch64 builds¹ will only be available going forward for new releases. Assumes the next release will be 8.2.0! Disables Rosetta check when using an aarch64 build, as the checks will be done at the runtime-level instead by `nextstrain setup` and `nextstrain check-setup`.² We must wait to merge this until after the first release (i.e. 8.2.0) of the changes it depends on above. ¹ <#357> ² <#361>
tsibley
force-pushed
the
trs/rosetta-checks
branch
from
3fd478f to
8856915
Compare
This was referenced Feb 2, 2024
tsibley
added a commit
to nextstrain/docs.nextstrain.org
that referenced
this pull request
Feb 2, 2024
… 8.2.0 Only the Conda runtime requires it. Related-to: <nextstrain/cli#357> Related-to: <nextstrain/cli#361> Related-to: <nextstrain/cli#358>
|
I've tested this on the Blab Mac mini running macOS 12 on aarch64. It works as expected there. Going to merge, but I'd welcome post-merge review! |
victorlin
reviewed
Feb 6, 2024
There was a problem hiding this comment.
- Tested using local git installation
$ nextstrain check-setup
nextstrain-cli is up to date!
Testing your setup…
# docker is supported
✔ yes: docker is installed
✔ yes: docker run works
✔ yes: containers have access to >2 GiB of memory (limit is 7.8 GiB)
✔ yes: image is new enough for this CLI version
✔ yes: Rosetta 2 is enabled for faster execution (optional)
# conda is supported
✔ yes: operating system is supported
✔ yes: Rosetta 2 is enabled
✔ yes: runtime data dir doesn't have spaces
✔ yes: runtime appears set up
✔ yes: snakemake is installed and runnable
✔ yes: augur is installed and runnable
✔ yes: auspice is installed and runnable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When on macOS on aarch64 hardware, the Conda runtime currently requires Rosetta. The Docker runtime does not require it, but can benefit from it because our aarch64 image isn't totally free of x86_64 code (yet?), so emulation is required and Rosetta is faster than QEMU.
The standalone installer still checks for Rosetta as we previously didn't produce aarch64 standalone binaries¹, but that check will be made conditional on Nextstrain CLI version in a subsequent commit² after the first release of aarch64 support and these new Rosetta checks.
¹ #357
² #358
Checklist