Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to cfg-if 1.0 #1313

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Update to cfg-if 1.0 #1313

merged 1 commit into from
Oct 15, 2020

Conversation

mbrubeck
Copy link
Contributor

No description provided.

@asomers
Copy link
Member

asomers commented Oct 12, 2020

Why? What is the benefit?

@mbrubeck
Copy link
Contributor Author

mbrubeck commented Oct 12, 2020 •
edited
Loading

The only change in this release is rust-lang/cfg-if#37, which removes some syntax that was inconsistent with the standard cfg macro and attributes and generated incorrect code in some cases.

There's no urgent reason to update right away, but once everyone has updated to latest version, it will reduce the need for downstream crates to download and compile two different versions of cfg-if. It will also make this library and its downstream consumers compatible with future 1.x versions of cfg-if.

asomers
asomers approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Oct 15, 2020
@bors @mbrubeck
Merge #1313
39dfa6f 
1313: Update to cfg-if 1.0 r=asomers a=mbrubeck



Co-authored-by: Matt Brubeck <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 15, 2020

Build failed:

@asomers
Copy link
Member

asomers commented Oct 15, 2020

bors retry

@bors
Copy link
Contributor

bors bot commented Oct 15, 2020

Build succeeded:

@bors bors bot merged commit 07f8d12 into nix-rust:master Oct 15, 2020
@lopopolo
Copy link

@asomers is it possible to get an 0.19 point release that contains this dep bump? I'm trying to update all of my transitive dependencies to cfg-if v1.

@asomers
Copy link
Member

asomers commented Nov 22, 2020

Yes. In fact, I would really like to do a point release just for #1337

@asomers asomers added this to the 0.19.1 milestone Nov 22, 2020
@lopopolo lopopolo mentioned this pull request Nov 23, 2020
Closed
@asomers
Copy link
Member

asomers commented Nov 29, 2020

https://crates.io/crates/nix/0.19.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.19.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mbrubeck @asomers @lopopolo