Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs.rs target list #1337

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Add docs.rs target list #1337

merged 1 commit into from
Nov 19, 2020

Conversation

valpackett
Copy link
Contributor

ref: https://blog.rust-lang.org/2020/03/15/docs-rs-opt-into-fewer-targets.html

Makes sense to build docs for all supported OSes (BSD, Redox) rather than completely empty docs for Windows :)

@asomers
Copy link
Member

asomers commented Nov 17, 2020

Oh, this is cool! I didn't know that doc.rs could do this. I thought that it gave you just Windows, OSX, and Linux and that was it.

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Nov 18, 2020
1337: Add docs.rs target list r=asomers a=myfreeweb

ref: https://blog.rust-lang.org/2020/03/15/docs-rs-opt-into-fewer-targets.html

Makes sense to build docs for all supported OSes (BSD, Redox) rather than completely empty docs for Windows :)

Co-authored-by: myfreeweb <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 19, 2020

Timed out.

@asomers
Copy link
Member

asomers commented Nov 19, 2020

bors retry

@bors
Copy link
Contributor

bors bot commented Nov 19, 2020

Build succeeded:

@bors bors bot merged commit 1794a47 into nix-rust:master Nov 19, 2020
@valpackett valpackett deleted the patch-1 branch November 19, 2020 12:09
@asomers asomers mentioned this pull request Nov 22, 2020
@asomers asomers added this to the 0.19.1 milestone Nov 22, 2020
@tamird tamird mentioned this pull request Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants