Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: ncu-team sync update #833

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

BethGriggs
Copy link
Member

ncu-team sync README.md

@ljharb
Copy link
Member

ljharb commented Mar 14, 2023

seems like maybe the citgm team isn't on the access list for this repo. should it be?

@BethGriggs
Copy link
Member Author

BethGriggs commented Mar 14, 2023

seems like maybe the release team isn't on the access list for this repo. should it be?

Oh hmm, it looks like CITGM GitHub team is not a subteam of the parent Release WG team. I cannot remember if that was always the case or the team structure got changed at some point.

Not sure whether we should make it a subteam, or just grant the CITGM team access to this repository also.

@ljharb
Copy link
Member

ljharb commented Mar 14, 2023

subteams get all the access their parent teams have, so it'd be more like, citgm was a parent of release - which probably doesn't make sense.

so i'd assume adding the citgm team specifically would make the most sense

@richardlau
Copy link
Member

Why would the CITGM team need access to the release repository?

@ljharb
Copy link
Member

ljharb commented Mar 14, 2023

@richardlau perhaps they don't. but this repo's readme lists the citgm team, and my approval here was gray instead of green.

¯\_(ツ)_/¯ just bringing it up, no strong feelings here

@BethGriggs
Copy link
Member Author

@ljharb it's a fair comment to raise - conceptually we have, and our wording implies, that the CITGM team is a subteam of the wider-Release WG and all other subteams of release have write access. If CITGM is an exception then we should be clear why.

Why would the CITGM team need access to the release repository?

At least to maintain their list of members. It's reasonable to decide not to grant access, but then maybe the member list for CITGM should be listed in a place where the team has access to review it.

@Trott
Copy link
Member

Trott commented Mar 14, 2023

@richardlau perhaps they don't. but this repo's readme lists the citgm team, and my approval here was gray instead of green.

¯_(ツ)_/¯ just bringing it up, no strong feelings here

CITGM was removed as a subteam from Release based on the conversations in nodejs/admin#737. As such, the thing to do is probably to move the CITGM members list to the CITGM repository.

@BethGriggs BethGriggs marked this pull request as draft March 15, 2023 16:41
BethGriggs added a commit to BethGriggs/citgm that referenced this pull request Mar 15, 2023
BethGriggs added a commit to nodejs/citgm that referenced this pull request Mar 20, 2023
@BethGriggs
Copy link
Member Author

Updated based on nodejs/citgm#944

@BethGriggs BethGriggs marked this pull request as ready for review March 22, 2023 11:35
@BethGriggs BethGriggs merged commit 031e2e6 into nodejs:main Mar 23, 2023
@BethGriggs BethGriggs deleted the ncu-team-sync-0323 branch March 23, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants