-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: ncu-team sync update #833
Conversation
seems like maybe the citgm team isn't on the access list for this repo. should it be? |
Oh hmm, it looks like CITGM GitHub team is not a subteam of the parent Release WG team. I cannot remember if that was always the case or the team structure got changed at some point. Not sure whether we should make it a subteam, or just grant the CITGM team access to this repository also. |
subteams get all the access their parent teams have, so it'd be more like, citgm was a parent of release - which probably doesn't make sense. so i'd assume adding the citgm team specifically would make the most sense |
Why would the CITGM team need access to the release repository? |
@richardlau perhaps they don't. but this repo's readme lists the citgm team, and my approval here was gray instead of green. ¯\_(ツ)_/¯ just bringing it up, no strong feelings here |
@ljharb it's a fair comment to raise - conceptually we have, and our wording implies, that the CITGM team is a subteam of the wider-Release WG and all other subteams of release have write access. If CITGM is an exception then we should be clear why.
At least to maintain their list of members. It's reasonable to decide not to grant access, but then maybe the member list for CITGM should be listed in a place where the team has access to review it. |
CITGM was removed as a subteam from Release based on the conversations in nodejs/admin#737. As such, the thing to do is probably to move the CITGM members list to the CITGM repository. |
9bf142d
to
41be67f
Compare
Updated based on nodejs/citgm#944 |
ncu-team sync README.md