WWW changes for ChakraCore nightlies and releases #547
Conversation
|
lgtm, nightly building crontab job lives in tasks/tools.yaml if you want to add that too, might need to adjust https://github.com/nodejs/nodejs-nightly-builder too I suppose |
joaocgreis
force-pushed
the
joaocgreis-GBH-tmp-chakra-nightlies
branch
from
2c26f8a to
c3525ef
Compare
|
Rebased and added changes to start the nightly build with |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
joaocgreis
changed the title
|
This has been live on the server for some months now, I believe we should land even if only to make Ansible consistent with what's in the server. This is likely to be improved in the future, but is stable as is. @nodejs/build if there are no objections I'll land this tomorrow. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
+1 on landing. |
Ref: #527 PR-URL: #547 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
PR-URL: #547 Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Ref: #781 PR-URL: #547 Reviewed-By: Gibson Fahnestock <[email protected]>
|
Thanks! Landed in 9774dae...e5d81e9 |
DO NOT LAND!This PR includes the changes made live in the server, to make them public and accept feedback. This was not tested with Ansible.
Ref: #527