add support for chakracore-nightly #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node-ChakraCore produces builds of type 'nightly' and uploads them to a directory named 'chakracore-nightly'. This adds support for a prefix that can be set to 'chakracore-'.
|
Updated: added a test. |
|
LGTM. but just curious, where is it triggered? Is it from release CI machines? |
|
@kunalspathak the web server runs this as a cron job. You can check the Ansible diff here: JaneaSystems/build@c3525ef (PR nodejs/build#547) |
joaocgreis
added a commit
that referenced
this pull request
Nov 2, 2017
Node-ChakraCore produces builds of type 'nightly' and uploads them to a directory named 'chakracore-nightly'. This adds support for a prefix that can be set to 'chakracore-'. PR-URL: #2 Reviewed-By: Kunal Pathak <[email protected]>
|
Landed in dd940e3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node-ChakraCore produces builds of type
nightlyand uploads them to a directory namedchakracore-nightly. This adds support for a prefix that can be set tochakracore-.This PR includes the commit under review in #1 by @rvagg , so this can be easily rebased after that PR lands.
cc @nodejs/build