Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect links #47070

Closed
albert-github opened this issue Mar 13, 2023 · 12 comments
Closed

Incorrect links #47070

albert-github opened this issue Mar 13, 2023 · 12 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@albert-github
Copy link

node/BUILDING.md

Line 991 in c2e4b1f

[Enabling FIPS using Node.js options](#enabling-fips-using-node.js-options) and

The link (#enabling-fips-using-node.js-options) should be (#enabling-fips-using-nodejs-options)

node/doc/api/net.md

Line 1732 in c2e4b1f

[`'error'`]: #event-error_1

The link #event-error_1 should be #event-error-1

Similar problems, probably:

  • process.md with processexitcode_1
  • worker_threads.md with workerthreadid_1
  • worker_threads.md withevent-message_1
@marco-ippolito marco-ippolito added the doc Issues and PRs related to the documentations. label Mar 13, 2023
@tniessen tniessen added the good first issue Issues that are suitable for first-time contributors. label Mar 13, 2023
@AFoaad
Copy link

AFoaad commented Mar 13, 2023

can I take this?

@bnoordhuis
Copy link
Member

@AFoaad go for it

noel046 added a commit to noel046/node that referenced this issue Mar 14, 2023
@noel046
update incorrect links nodejs#47070
05f31e8
AFoaad added a commit to AFoaad/node that referenced this issue Mar 14, 2023
@AFoaad
doc: fix incorrect link
eeb246d 
Fixes: nodejs#47070
Robot-dev11 pushed a commit to Robot-dev11/node that referenced this issue Mar 14, 2023
subsystem: changes for good-first-issue incorrect links nodejs#47070
ebe78c1 
Changes in BUILDING.md, net.md, process.md and worker_threads.md file for issue nodejs#47070

Fixes: nodejs#47070
@Robot-dev11 Robot-dev11 mentioned this issue Mar 14, 2023
Closed
@nexuspy
Copy link

nexuspy commented Mar 14, 2023

can I take this?

@MoLow
Copy link
Member

MoLow commented Mar 14, 2023

@nexuspy there is already an open PR handling this #47089

Robot-dev11 pushed a commit to Robot-dev11/node that referenced this issue Mar 14, 2023
doc: fix incorrect links
633bfa5 
Changes in BUILDING.md, net.md, process.md and worker_threads.md file for issue nodejs#47070

Fixes: nodejs#47070
noel046 added a commit to noel046/node that referenced this issue Mar 14, 2023
@noel046
Merge branch 'nodejs:main' into Incorrect-links-nodejs#47070
f9629a7
Robot-dev11 pushed a commit to Robot-dev11/node that referenced this issue Mar 14, 2023
@Robot-dev11
doc: fix incorrect links
18481f3 
Changes in BUILDING.md, net.md, process.md and worker_threads.md file for issue nodejs#47070
Fixes: nodejs#47070
Robot-dev11 pushed a commit to Robot-dev11/node that referenced this issue Mar 15, 2023
@Robot-dev11
doc: fix incorrect links
51ea3ff 
fix incorrect links nodejs#47070
Fixes: nodejs#47070
amirzarie added a commit to amirzarie/node that referenced this issue Mar 15, 2023
@amirzarie
Fixed Incorrect Links
676b338 
Corrected the links in the following two files as requested:
1. File node/BUILDING.md:
- [Enabling FIPS using Node.js options](#enabling-fips-using-node.js-options)
+ [Enabling FIPS using Node.js options](#enabling-fips-using-nodejs-options)

and

2. File node/doc/api/net.md:
- []: #event-error_1
+ []: #event-error-1

Issue: nodejs#47070
@amirzarie amirzarie mentioned this issue Mar 15, 2023
Closed
Robot-dev11 pushed a commit to Robot-dev11/node that referenced this issue Mar 15, 2023
doc: fix incorrect links
3b8a8e9 
Changes in BUILDING.md, net.md, process.md and worker_threads.md file for issue nodejs#47070

Fixes: nodejs#47070
Robot-dev11 pushed a commit to Robot-dev11/node that referenced this issue Mar 15, 2023
doc: fix incorrect links
7de1997 
Revert changes of process.md and worker_threads.md
Fixes: nodejs#47070
@muhammadIhtishamKhan
Copy link

Can I work on this issue?

@RamGoel
Copy link

RamGoel commented Mar 25, 2023

This issue has been fixed or not?

@abdulmajid19
Copy link

What is the result of this issue please?

@albert-github
Copy link
Author

The result is that the links can be followed on e.g. GitHub.

VALiUMgithub added a commit to VALiUMgithub/node that referenced this issue Mar 31, 2023
@VALiUMgithub
fixed nodejs#47070
b9da590 
fixed the broken link at line 988, Enabling FIPS using Node.js options.
VALiUMgithub added a commit to VALiUMgithub/node that referenced this issue Mar 31, 2023
@VALiUMgithub
Merge pull request #1 from VALiUMgithub/VALiUMgithub--nodejs#47070
4b259de 
fixed  nodejs#47070
VALiUMgithub added a commit to VALiUMgithub/node that referenced this issue Mar 31, 2023
@VALiUMgithub
fixed broken link nodejs#47070
f75df56 
fixed the broken link at line 988, Enabling FIPS using Node.js options.
@hanshal101
Copy link

please assign me this issue

@birajkarki
Copy link

I am new to this , can i contribute on this or any where ,

@mscdex
Copy link
Contributor

mscdex commented Apr 7, 2023

For anyone seeing this thread, there is already a PR to fix these things here.

@utkarsh4084 utkarsh4084 mentioned this issue Apr 8, 2023
Closed
@mscdex mscdex removed the good first issue Issues that are suitable for first-time contributors. label Apr 8, 2023
rv97 added a commit to rv97/node that referenced this issue Apr 22, 2023
@rv97
doc: Fixed the incorrect links
d7e0371 
This PR fixes the issue with the incorrect links.

Fixes: nodejs#47070
rv97 added a commit to rv97/node that referenced this issue Apr 22, 2023
@rv97
doc: Fixing incorrect links
ce34794 
This commit fixes the incorrect links

Fixes: nodejs#47070
@rv97 rv97 mentioned this issue Apr 22, 2023
Closed
@aduh95 aduh95 mentioned this issue Sep 20, 2023
Closed
@aduh95
Copy link
Contributor

aduh95 commented Sep 20, 2023

The incorrect link(s) was/were removed in 8aa02e8.

@aduh95 aduh95 closed this as completed Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone