-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix incorrect links #47089
doc: fix incorrect links #47089
Conversation
Review requested:
|
@Robot-dev11 thanks for your contribution! the commit message should describe the fix directly, and the subsystem is |
Hi @MoLow, I have changed the commit message. Can you review please Thanks, |
@Robot-dev11 the change you have performed only changed the PR name. |
ebe78c1
to
633bfa5
Compare
Yeah, @MoLow Sorry for that i have also done amend for commit and force to push it |
18481f3
to
51ea3ff
Compare
Hi, Thanks |
doc/api/worker_threads.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the changes in this file are not required, these changes are making the workflow fail, I tested locally. you can test it locally too by running make doc
and check any failures
Changes in BUILDING.md, net.md, process.md and worker_threads.md file for issue nodejs#47070 Fixes: nodejs#47070
Revert changes of process.md and worker_threads.md Fixes: nodejs#47070
51ea3ff
to
7de1997
Compare
There is already a PR open for these changes here. |
[`'error'`]: #event-error_1 | ||
[`'error'`]: #event-error-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current anchor exists in our HTML docs. The new one proposed here does not. What is the motivation for this change? Is it to fix something in the GitHub markdown rendering of this doc?
Changes in BUILDING.md, net.md, process.md and worker_threads.md file for issue #47070
Fixes: #47070