Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused http2_socket_buffer from env #14740

Closed
wants to merge 1 commit into from
Closed

src: remove unused http2_socket_buffer from env #14740

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

I’d go so far as to say that this doesn’t need to wait 48 hours.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. labels Aug 10, 2017
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 10, 2017
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/11687/

@addaleax
Copy link
Member Author

Landed in 1419533

@addaleax addaleax closed this Aug 10, 2017
@addaleax addaleax deleted the http2-socket-buffer branch August 10, 2017 15:15
addaleax added a commit to addaleax/node that referenced this pull request Aug 10, 2017
@addaleax
src: remove unused http2_socket_buffer from env
1419533 
PR-URL: nodejs#14740
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@jasnell
Copy link
Member

jasnell commented Aug 10, 2017

Whoops! I thought I had removed that one already! Thank you @addaleax! :-D

jasnell pushed a commit to jasnell/node that referenced this pull request Aug 13, 2017
@addaleax @jasnell
src: remove unused http2_socket_buffer from env
5db4971 
PR-URL: nodejs#14740
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
addaleax added a commit that referenced this pull request Aug 14, 2017
@addaleax
src: remove unused http2_socket_buffer from env
59d1d56 
PR-URL: #14740
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@addaleax addaleax mentioned this pull request Aug 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @jasnell @bnoordhuis @cjihrig @tniessen @MylesBorins @nodejs-github-bot