Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused http2_socket_buffer from env #14740

Closed
wants to merge 1 commit into from
+0 −14
Closed

src: remove unused http2_socket_buffer from env #14740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/env-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,6 @@ inline Environment::Environment(IsolateData* isolate_data,
#endif
handle_cleanup_waiting_(0),
http_parser_buffer_(nullptr),
http2_socket_buffer_(nullptr),
fs_stats_field_array_(nullptr),
context_(context->GetIsolate(), context) {
// We'll be creating new objects so make sure we've entered the context.
Expand All @@ -329,7 +328,6 @@ inline Environment::~Environment() {
delete[] heap_statistics_buffer_;
delete[] heap_space_statistics_buffer_;
delete[] http_parser_buffer_;
delete[] http2_socket_buffer_;
}

inline v8::Isolate* Environment::isolate() const {
Expand Down Expand Up @@ -488,15 +486,6 @@ inline void Environment::set_fs_stats_field_array(double* fields) {
fs_stats_field_array_ = fields;
}

inline char* Environment::http2_socket_buffer() const {
return http2_socket_buffer_;
}

inline void Environment::set_http2_socket_buffer(char* buffer) {
CHECK_EQ(http2_socket_buffer_, nullptr); // Should be set only once.
http2_socket_buffer_ = buffer;
}

inline IsolateData* Environment::isolate_data() const {
return isolate_data_;
}
Expand Down
3 changes: 0 additions & 3 deletions src/env.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,8 +598,6 @@ class Environment {

inline char* http_parser_buffer() const;
inline void set_http_parser_buffer(char* buffer);
inline char* http2_socket_buffer() const;
inline void set_http2_socket_buffer(char* buffer);

inline double* fs_stats_field_array() const;
inline void set_fs_stats_field_array(double* fields);
Expand Down Expand Up @@ -707,7 +705,6 @@ class Environment {
double* heap_space_statistics_buffer_ = nullptr;

char* http_parser_buffer_;
char* http2_socket_buffer_;

double* fs_stats_field_array_;

Expand Down