lib: move deprecationWarned var #14769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable deprecationWarned currently looks a little misplaced. It is used in emitWarning but declared after it. This commit suggest moving the var to the beginning of the function.
nodejs-github-bot
added
the
process
cjihrig
approved these changes
Aug 11, 2017
aqrln
approved these changes
Aug 11, 2017
| @@ -14,6 +14,8 @@ function getAsynchronousRejectionWarningObject(uid) { | |||
| } | |||
|
|
|||
| function setupPromises(scheduleMicrotasks) { | |||
| var deprecationWarned = false; | |||
There was a problem hiding this comment.
IMO, it would be nice to change it to let while you are here, but LGTM either way.
There was a problem hiding this comment.
Unless it triggers deopts of course 😁
lpinca
approved these changes
Aug 12, 2017
tniessen
approved these changes
Aug 12, 2017
refack
approved these changes
Aug 12, 2017
gibfahn
approved these changes
Aug 12, 2017
jasnell
approved these changes
Aug 13, 2017
danbev
added a commit
to danbev/node
that referenced
this pull request
Aug 14, 2017
The variable deprecationWarned currently looks a little misplaced. It is used in emitWarning but declared after it. This commit suggest moving the var to the beginning of the function. PR-URL: nodejs#14769 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 170ff0e |
addaleax
pushed a commit
that referenced
this pull request
Aug 14, 2017
The variable deprecationWarned currently looks a little misplaced. It is used in emitWarning but declared after it. This commit suggest moving the var to the beginning of the function. PR-URL: #14769 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable deprecationWarned currently looks a little misplaced. It is
used in emitWarning but declared after it. This commit suggest moving
the var to the beginning of the function.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib