Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: move deprecationWarned var #14769

Closed
wants to merge 1 commit into from
Closed

lib: move deprecationWarned var #14769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/internal/process/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ function getAsynchronousRejectionWarningObject(uid) {
}

function setupPromises(scheduleMicrotasks) {
var deprecationWarned = false;
Copy link
Contributor

@aqrln aqrln Aug 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it would be nice to change it to let while you are here, but LGTM either way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it triggers deopts of course 😁


process._setupPromises(function(event, promise, reason) {
if (event === promiseRejectEvent.unhandled)
unhandledRejection(promise, reason);
Expand Down Expand Up @@ -73,7 +75,7 @@ function setupPromises(scheduleMicrotasks) {
'DeprecationWarning', 'DEP0018');
}
}
var deprecationWarned = false;

function emitPendingUnhandledRejections() {
let hadListeners = false;
while (pendingUnhandledRejections.length > 0) {
Expand Down