Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve message for assert.strictEqual() #16013

Closed
wants to merge 2 commits into from
Closed

test: improve message for assert.strictEqual() #16013

wants to merge 2 commits into from

Conversation

Deep-Six
Copy link
Contributor

@Deep-Six Deep-Six commented Oct 6, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Oct 6, 2017
evanlucas
evanlucas approved these changes Oct 6, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

CI: https://ci.nodejs.org/job/node-test-pull-request/10427/

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
@joyeecheung
Copy link
Member

Previous CI is 404 now. New CI: https://ci.nodejs.org/job/node-test-pull-request/10673/

joyeecheung
joyeecheung reviewed Oct 13, 2017
View reviewed changes
test/addons-napi/test_exception/test.js Outdated
@@ -12,7 +12,8 @@ let caughtError;
// Test that the native side successfully captures the exception
let returnedError = test_exception.returnException(throwTheError);
assert.strictEqual(theError, returnedError,
'Returned error is strictly equal to the thrown error');
`Returned error ${returnedError.message}` +
` is strictly equal to the thrown error ${theError.message}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter complained:

not ok 23 - /usr/home/iojs/build/workspace/node-test-linter/test/addons-napi/test_exception/test.js
  ---
  message: Line 16 exceeds the maximum line length of 80.
  severity: error
  data:
    line: 16
    column: 1
    ruleId: max-len
  ...

I think we can just remove the assertion message (third argument) here, that would actually be more readable.

@BridgeAR
Copy link
Member

@Deep-Six would you be so kind and please remove the error message as suggested?

@targos
Copy link
Member

targos commented Oct 22, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10894/

gireeshpunathil pushed a commit that referenced this pull request Oct 22, 2017
@Deep-Six @gireeshpunathil
test: improve message for assert.strictEqual()
e07e708 
PR-URL: #16013
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@gireeshpunathil
Copy link
Member

Landed in e07e708 . Thanks @Deep-Six for the contribution!

MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@Deep-Six @MylesBorins
test: improve message for assert.strictEqual()
d7b4ad8 
PR-URL: #16013
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@Deep-Six @addaleax
test: improve message for assert.strictEqual()
d2c3dcb 
PR-URL: nodejs/node#16013
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@Deep-Six @addaleax
test: improve message for assert.strictEqual()
fd5eb50 
PR-URL: nodejs/node#16013
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
@Deep-Six
test: improve message for assert.strictEqual()
e2b58ab 
PR-URL: nodejs#16013
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@Deep-Six @MylesBorins
test: improve message for assert.strictEqual()
9cc435d 
Backport-PR-URL: #19447
PR-URL: #16013
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@targos targos targos approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Deep-Six @joyeecheung @BridgeAR @targos @gireeshpunathil @jasnell @evanlucas @Trott @nodejs-github-bot