Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve message for assert.strictEqual() #16013

Closed
wants to merge 2 commits into from
Closed

test: improve message for assert.strictEqual() #16013

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58796c6
test: improve message for assert.strictEqual()
Deep-Six Oct 6, 2017
10348e2
Update test.js
Deep-Six Oct 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/addons-napi/test_exception/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ let caughtError;
// Test that the native side successfully captures the exception
let returnedError = test_exception.returnException(throwTheError);
assert.strictEqual(theError, returnedError,
'Returned error is strictly equal to the thrown error');
`Returned error ${returnedError.message}` +
` is strictly equal to the thrown error ${theError.message}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter complained:

not ok 23 - /usr/home/iojs/build/workspace/node-test-linter/test/addons-napi/test_exception/test.js
  ---
  message: Line 16 exceeds the maximum line length of 80.
  severity: error
  data:
    line: 16
    column: 1
    ruleId: max-len
  ...

I think we can just remove the assertion message (third argument) here, that would actually be more readable.


// Test that the native side passes the exception through
assert.throws(
Expand Down