Refactor of test-tls-over-http-tunnel #18784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Feb 14, 2018
BridgeAR
approved these changes
Feb 15, 2018
Trott
reviewed
Feb 15, 2018
| @@ -24,6 +24,9 @@ const common = require('../common'); | |||
| if (!common.hasCrypto) | |||
| common.skip('missing crypto'); | |||
|
|
|||
| // This test ensures that the data throught tls over http tunnel | |||
There was a problem hiding this comment.
Typo: throught -> through
Also, probably data received through rather than just data through?
There was a problem hiding this comment.
changes made. Thank you @Trott for feedback
danbev
approved these changes
Feb 16, 2018
BridgeAR
approved these changes
Feb 16, 2018
BridgeAR
added
the
author ready
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 16, 2018
PR-URL: nodejs#18784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
|
Landed in 2960096 🎉 @juggernaut451 I fixed the commit message while landing. Please check our commit guidelines briefly. They are always included as default text when opening a PR. Those checkboxes should actually also be checked accordingly :-) |
|
@BridgeAR will read it and will keep check from next time. |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 7, 2018
PR-URL: #18784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
Changes that are done in file are :
#14544