test: good-second-contribution — tracking tests that need some more 💘 #14544
Comments
refack
added
help wanted
|
I was thinking something more extensive, and obviously the "list" is going to get longer... |
|
Like what you did in #14534 |
|
@nodejs/testing please add/remove/comment/edit |
|
Can I take this up ? |
Sure. If you need any help, ping me (here or on IRC). |
|
Hi @refack I am looking for an issue for my first contribution. May be I can work on this? |
|
@okyantoro @refack A little with held upwith stuffs, Feel free to reassign this |
|
I observed some test files and I found parallel/test-http-methods.js only covered GET, HEAD and POST and the last case compares the http.METHODS with http.METHODS.sort() |
Assuming it isn't duplicating another test that we already have, more test coverage is 👍 |
Add more case to check existence of DELETE and PUT methods. Refs: nodejs#14544
Cover all request methods that Node's HTTP parser supports in parallel/test-http-methods. PR-URL: #14773 Refs: #14544 Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Cover all request methods that Node's HTTP parser supports in parallel/test-http-methods. PR-URL: #14773 Refs: #14544 Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Cover all request methods that Node's HTTP parser supports in parallel/test-http-methods. PR-URL: #14773 Refs: #14544 Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
hi, one of the links in issue is broken, it points to https://github.com/nodejs/node/blob/master/test/sequential/test-domain-abort-on-uncaught.js |
|
@jonask-wix fixed. |
Added assertions to verify that console.time() coerces labels to strings correctly, by comparing against the expected output values of console.timeEnd(). This helps resolve nodejs#14544 but will not address the whole thing. Refs: nodejs#14643
|
Hey @refack, the following point has been done in PR #17368 :
Also, please open this issue again since refactoring of other files still needs to be done. Thanks! 🙂 |
Added assertions to verify that console.time() coerces labels to strings correctly, by comparing against the expected output values of console.timeEnd(). This helps resolve #14544 but will not address the whole thing. PR-URL: #17368 Refs: #14643 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Added assertions to verify that console.time() coerces labels to strings correctly, by comparing against the expected output values of console.timeEnd(). This helps resolve #14544 but will not address the whole thing. PR-URL: #17368 Refs: #14643 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
hello @NiveditN can you please tell which all files are to be refactored. As i would like to help on this |
|
Anyone available for mentoring me regarding this issue? Would like to contribute |
|
@juggernaut451 a lot of our tests do not contain a description what they actually test. That would for example be a good thing to add. Another thing that I am aware of is that our documentation lacks a lot of "changed" entries. The latter is probably quite some work though to check all the changes. Even though you probably only have to check the concrete API history and check when what API changed and if a changed entry was added or not. |
|
Please also look at https://www.nodetodo.org/next-steps/ |
Implementing common.mustCall and changing the function to arrow function Fixes : nodejs#14544
added common.mustCall and replaced function with arrow function Fixes : nodejs#14544
PR-URL: #19092 Fixes: #14544 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Added common.mustCall and replaced function with arrow function. PR-URL: nodejs#19096 Fixes: nodejs#14544 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Added common.mustCall and replaced function with arrow function. PR-URL: #19096 Fixes: #14544 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
PR-URL: #19092 Fixes: #14544 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
A very biased list of tests that could enjoy some non-trivial refactoring
test/commonutilitiesnew entries
stdoutand don't throw.The text was updated successfully, but these errors were encountered: