Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test-tls-0-dns-altname #18803

Closed
wants to merge 1 commit into from
Closed

Refactor test-tls-0-dns-altname #18803

wants to merge 1 commit into from

Conversation

juggernaut451
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Changes that are done in file are :

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 15, 2018
benjamingr
benjamingr approved these changes Feb 15, 2018
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this :) Welcome to the project.

What will happen now is that collaborators will review this PR for 72 hours and then (if no objections arise) it will land.

If you feel like it - feel free to check https://github.com/nodejs/node/blob/master/CONTRIBUTING.md and specifically the section about how commit messages might look. Amending your commit message is explained there too. If you don't feel like it - a collaborator will do this for you when landing since this is your first contribution

@juggernaut451
Copy link
Contributor Author

Thank you @benjamingr

@jasnell
Copy link
Member

jasnell commented Feb 16, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13207/

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 16, 2018
@juggernaut451 juggernaut451 force-pushed the refactorTestTls0DnsAltname branch from 83d2ecd to a21180f Compare February 16, 2018 21:05
@jasnell
Copy link
Member

jasnell commented Feb 17, 2018

Failure in CI appears unrelated.

jasnell pushed a commit that referenced this pull request Feb 17, 2018
@juggernaut451 @jasnell
test: refactor parallel/test-tls-0-dns-altname
760f86c 
PR-URL: #18803
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 17, 2018

Landed in 760f86c

@jasnell jasnell closed this Feb 17, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-0-dns-altname
1fb4cc9 
PR-URL: #18803
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-0-dns-altname
ff43209 
PR-URL: #18803
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-0-dns-altname
dba5e35 
PR-URL: #18803
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@juggernaut451 @MayaLekova
test: refactor parallel/test-tls-0-dns-altname
853cb48 
PR-URL: nodejs#18803
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-0-dns-altname
f3c15ae 
PR-URL: #18803
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-0-dns-altname
bc8bc81 
PR-URL: #18803
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-0-dns-altname
d05a652 
PR-URL: #18803
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-0-dns-altname
488e1bb 
PR-URL: #18803
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juggernaut451 @jasnell @benjamingr @richardlau @BridgeAR @nodejs-github-bot